diff --git a/common.gypi b/common.gypi index bf9556e77bd364..925d85f4fc1009 100644 --- a/common.gypi +++ b/common.gypi @@ -37,7 +37,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.7', + 'v8_embedder_string': '-node.8', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h index ac96091ef6b284..0a19d1aef36699 100644 --- a/deps/v8/include/v8.h +++ b/deps/v8/include/v8.h @@ -6717,11 +6717,8 @@ enum PromiseRejectEvent { class PromiseRejectMessage { public: PromiseRejectMessage(Local promise, PromiseRejectEvent event, - Local value, Local stack_trace) - : promise_(promise), - event_(event), - value_(value), - stack_trace_(stack_trace) {} + Local value) + : promise_(promise), event_(event), value_(value) {} V8_INLINE Local GetPromise() const { return promise_; } V8_INLINE PromiseRejectEvent GetEvent() const { return event_; } @@ -6731,7 +6728,6 @@ class PromiseRejectMessage { Local promise_; PromiseRejectEvent event_; Local value_; - Local stack_trace_; }; typedef void (*PromiseRejectCallback)(PromiseRejectMessage message); diff --git a/deps/v8/src/isolate.cc b/deps/v8/src/isolate.cc index 73aee01a6d2dee..8187284ba83db9 100644 --- a/deps/v8/src/isolate.cc +++ b/deps/v8/src/isolate.cc @@ -4400,13 +4400,8 @@ void Isolate::ReportPromiseReject(Handle promise, Handle value, v8::PromiseRejectEvent event) { if (promise_reject_callback_ == nullptr) return; - Handle stack_trace; - if (event != v8::kPromiseHandlerAddedAfterReject && value->IsJSObject()) { - stack_trace = GetDetailedStackTrace(Handle::cast(value)); - } promise_reject_callback_(v8::PromiseRejectMessage( - v8::Utils::PromiseToLocal(promise), event, v8::Utils::ToLocal(value), - v8::Utils::StackTraceToLocal(stack_trace))); + v8::Utils::PromiseToLocal(promise), event, v8::Utils::ToLocal(value))); } void Isolate::SetUseCounterCallback(v8::Isolate::UseCounterCallback callback) {