Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the preferences button (Improve UI as well) and info button #227

Open
3 of 5 tasks
anshumanv opened this issue Oct 24, 2017 · 11 comments
Open
3 of 5 tasks

Merge the preferences button (Improve UI as well) and info button #227

anshumanv opened this issue Oct 24, 2017 · 11 comments

Comments

@anshumanv
Copy link
Owner

Currently, we have preferences and info button aligned side by side. Let's merge them into a single button called settings, and by clicking the button we have foldable sections to preferences and keycodes each, a good example is in http://openings.moe (Menu button) we need something along those lines.

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This issue is for enhancement/bug fixing.
  • This issue is an addition to JSON database.
  • I have gone through Contribution Guidelines.
  • Assign this issue to me.
@SoldierCorp
Copy link
Contributor

Are you sure?

In my opinion the way you have the buttons set looks good and is a quick access which is better.

@anshumanv
Copy link
Owner Author

In that case, let's improve the keycode info button, I don't like the current button, it's buggy and not well modeled.

@SoldierCorp
Copy link
Contributor

Agree

@anshumanv
Copy link
Owner Author

In that case, please improve the info button UI and send a PR. 😄

@OuKevin
Copy link
Contributor

OuKevin commented Nov 8, 2017

What about making it behave similar to the preference button? or do you have something else in mind?

@anshumanv
Copy link
Owner Author

@OuKevin let's make it similar to the preferences button (with improved UI), please send a PR.

@starkblaze01
Copy link
Collaborator

Remove Hacktoberfest label

@Shiroraven
Copy link

Help still needed?

@anshumanv
Copy link
Owner Author

Sure, please feel free to send a PR @Shiroraven 😄

@Shiroraven
Copy link

@anshumanv is there any way to contact you to discuss what changes need to be made to the UI, because from reading the issue alone i don't quite understand.

@anshumanv
Copy link
Owner Author

Sure @Shiroraven you can contact me on telegram, my handle - @anshumanv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants