Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Expand Pivot on a Blank Cell #123

Closed
Ga68 opened this issue Apr 5, 2018 · 1 comment
Closed

Can't Expand Pivot on a Blank Cell #123

Ga68 opened this issue Apr 5, 2018 · 1 comment
Labels

Comments

@Ga68
Copy link

Ga68 commented Apr 5, 2018

When I pivot on a given column, there's values V1, V2, V3, etc. and in this case, there are some rows with no value (NULL, blank, etc.). They all get grouped together, which seems right, but when I click the + sign next to it to expand, they won't expand. All the row-groups with a value in the pivoted column expand as expected.

@antonycourtney
Copy link
Owner

I investigated this because it bit me yesterday. It turns out to come down to sloppy / inconsistent handling of null values in string columns. Some notes in case I get some cycles to eventually fix this:
First: Our fast CSV import code seems to be importing empty strings from CSV files as null instead of as empty strings. It's actually not clear whether that's the right behavior. But since we want Tad to ultimately be usable for any kind of database table viewing (not just CSV files), it seems worth handling NULL values correctly.
Second: Our encoding of pivot tree paths in aggtree.js uses a null value in the synthetic _pathN columns as a path terminator. This processing happens in onGridClick() in GridPane.
We should probably just encode the length explicitly in aggtree.js to avoid this overloaded interpretation of NULL values for strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants