Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with associations when describing using symbol #53

Closed
anykeyh opened this issue Dec 21, 2018 · 1 comment
Closed

Problem with associations when describing using symbol #53

anykeyh opened this issue Dec 21, 2018 · 1 comment

Comments

@anykeyh
Copy link
Owner

anykeyh commented Dec 21, 2018

Related to #52

Problem

The associations are not working when using Symbol instead of Strings.
Moreover, the associations code is very complex and should be clean-up a little bit.

Solution

I'll rewrite and clean the association code to make it more easy to maintain. I'll add some boilerplate code to transform symbols to strings when needed.

anykeyh added a commit that referenced this issue Dec 24, 2018
* Refactoring the relations building. Extract the boilerplate from the
code generation.
* Refactoring of the relations, fix initialize and finalize mess
* Use of event manager for validation and saving callbacks
* Add event spec + change the order of the callback
* Adding clear/core to require clear without CLI + Extensions
* Changing the migration operation from struct to class; adding reference
to migration; improving the errors messages
* Fix typo: print_update_current_data
* Rewriting a bit the style + comments
* Use monotonic time for query logger
* Update to newer shard versions + fix styling issue (ameba)
@anykeyh
Copy link
Owner Author

anykeyh commented Dec 24, 2018

fixed by #54

@anykeyh anykeyh closed this as completed Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant