-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More type hints for Amazon provider #11297
Comments
Since you mentioned in last issue comment I had a look and it make sense to try it here. I can have a look. |
Cool, thanks. Not super important, this can wait if you'd like to work on other Type hints first. Completely up to you :) |
Yup, just gonna do some checks and then switch to other type hints 🙂 |
I'm interested in helping with this too, I was just looking at the AWS provider typehints and came across the same library. |
I'm interested in this issue too. |
I'm working on #11531. But I feel it's too large to ask for review. Should I divide into some small requests? |
Sure got for it |
@potix2 @mlgruby @scrambldchannel I assigned you to this ticket 🐱 |
@potix2 @mlgruby @scrambldchannel Do you need any help? If you have any questions about this ticket, I will be happy to explain. |
I have started to work on this, sorry initially got distracted by professional work. I might shout out for help later. But for now I am good. |
I'm working on #10742, but it's a little harder than I expected. After complete it, I'll be back to this issue. |
@mik-laj - came back to this after seeing a new comment on an old PR: https://github.com/apache/airflow/pull/10164/files#r653685526 It looks like Do you have a preference? Do you know if either of these have yet been installed? Guessing no. |
boto3_type_annotations is deprecated. We should use boto3-stubs. |
I do not a time and desire to complete this (and other) tasks. |
Description
The
boto3
used by Amazon provider generates new classes at runtime, so mypy is not aware of types. Luckily, there is a package that has generated type annotations, but we have to install them separately -boto3-stubs
It would be nice for us to check if this library meets our expectations and integrate it with our CI.
CC: @kaxil @mlgruby @coopergillan
Use case / motivation
This will allow us to detect more problems during the static check. It will also provide a better development experience as the IDE will be able to suggest types.
Related Issues
N/A
The text was updated successfully, but these errors were encountered: