Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage pools in Helm Chart #11707

Open
mik-laj opened this issue Oct 21, 2020 · 13 comments
Open

Manage pools in Helm Chart #11707

mik-laj opened this issue Oct 21, 2020 · 13 comments
Assignees
Labels
area:helm-chart Airflow Helm Chart good first issue kind:feature Feature Requests

Comments

@mik-laj
Copy link
Member

mik-laj commented Oct 21, 2020

Hello,

Many users need to deployment Airlfow and initialize instances with basic resources. It would be helpful if Helm Chart would facilitate this task.

For connections and variables, all we need to do is add documentation that describes the use of environment variables.

For pools, we will have to add a new script that initializes the database using the CLI.
https://airflow.readthedocs.io/en/latest/cli-and-env-variables-ref.html#pools

Similar tasks can be done with Terraform provider as well, but it's still WIP and not everyone uses Terraform. We still need better support for this use case in the Helm Chart.

Best regards,
Kamil Breguła

@mik-laj mik-laj added kind:feature Feature Requests area:helm-chart Airflow Helm Chart good first issue labels Oct 21, 2020
@FloChehab
Copy link
Contributor

FloChehab commented Oct 23, 2020

Hello, giving this issue a big 👍

This feature (creating pools) is already available in another chart, so if someone needs inspirations for this: https://github.com/helm/charts/blob/master/stable/airflow/templates/scheduler/scheduler-deployment.yaml#L250

@OmairK
Copy link
Contributor

OmairK commented Oct 28, 2020

Hi @mik-laj, is this issue up for taking?

@mik-laj
Copy link
Member Author

mik-laj commented Oct 28, 2020

@OmairK Assigned.

@FloChehab
Copy link
Contributor

Hello @OmairK did you have time to start looking at this issue or would you need an extra hand ?

@OmairK
Copy link
Contributor

OmairK commented Jan 9, 2021

Hello @FloChehab, I wont be able to work on this issue right now due to some academic commitments. So please go ahead and unassign me from this issue.

@mik-laj mik-laj assigned FloChehab and unassigned OmairK Jan 9, 2021
@mik-laj
Copy link
Member Author

mik-laj commented Jan 9, 2021

@FloChehab Assigned. ;-)

@FloChehab
Copy link
Contributor

Hello @FloChehab, I wont be able to work on this issue right now due to some academic commitments. So please go ahead and unassign me from this issue.

No worries @OmairK , good luck with your commitments !

For connections and variables, all we need to do is add documentation that describes the use of environment variables.

@mik-laj Just to make sure, for now we stick with the Readme in the chart folder? Or is something else expected ?

@mik-laj
Copy link
Member Author

mik-laj commented Jan 9, 2021

in my opinion it is enough to describe the creation of environment variables. Do you have a different idea for a solution?

@FloChehab
Copy link
Contributor

in my opinion it is enough to describe the creation of environment variables. Do you have a different idea for a solution?

No, that what's I was thinking. Just wanted to double check.

@ashb
Copy link
Member

ashb commented Feb 11, 2021

Connections and Variables can now come form secrets manager, which is better placed to handle this than baking them in to the chart.

Pools make sense.

@ashb ashb changed the title Manage connections, variables, pools in Helm Chart Manage pools in Helm Chart Feb 11, 2021
@FloChehab
Copy link
Contributor

Hello, just wanted to let you now that I should have time to work on this issue in couple of weeks.

FloChehab pushed a commit to FloChehab/airflow that referenced this issue Mar 30, 2021
* Pools can now be added throught the airflowPools value
* Docs also updated in that regard

Done in collaboration with @abrasseu @Jattakuy @JonathanCiglia
 @manzkel .

Closes apache#11707
@thesuperzapper
Copy link
Contributor

I want to highlight that the "user-community" chart (this is separate from the "official") supports this.

See "How to create airflow pools?" for documentation.

@csp33
Copy link
Contributor

csp33 commented Feb 7, 2023

I'll try to do this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart good first issue kind:feature Feature Requests
Projects
None yet
8 participants