Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the configuration iterator in FileSystem provider #6563

Open
yuqi1129 opened this issue Feb 27, 2025 · 1 comment · May be fixed by #6576
Open

Optimize the configuration iterator in FileSystem provider #6563

yuqi1129 opened this issue Feb 27, 2025 · 1 comment · May be fixed by #6576
Assignees
Labels
help wanted Extra attention is needed

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Feb 27, 2025

The following code is very time-consuming in FileSystemProvider like HDFSFileSystemProvider and needs to be optimized according to performance test:

    Configuration configuration = new Configuration();
    config.forEach(
        (k, v) -> {
          configuration.set(k.replace(GRAVITINO_BYPASS, ""), v);
        });
Image

The operation configuration.set() will take much time.

We can convert the map to an XML stream and store the XML stream in the configuration only once.

@yuqi1129 yuqi1129 added the help wanted Extra attention is needed label Feb 28, 2025
@sunxiaojian
Copy link
Contributor

@yuqi1129 please assign it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
2 participants