Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsar-admin] getPartitionedTopicMetadata method supports setting automatic topic create #11923

Closed
shibd opened this issue Sep 4, 2021 · 3 comments
Assignees
Labels
lifecycle/stale type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Comments

@shibd
Copy link
Member

shibd commented Sep 4, 2021

Describe the solution you'd like

PersistentTopics Interface supports setting automatic topic create. However, admin does not support this configuration.

PersistentTopics#getPartitionedMetadata

    public PartitionedTopicMetadata getPartitionedMetadata(
            @ApiParam(value = "Specify the tenant", required = true)
            @PathParam("tenant") String tenant,
            @ApiParam(value = "Specify the namespace", required = true)
            @PathParam("namespace") String namespace,
            @ApiParam(value = "Specify topic name", required = true)
            @PathParam("topic") @Encoded String encodedTopic,
            @ApiParam(value = "Is authentication required to perform this operation")
            @QueryParam("authoritative") @DefaultValue("false") boolean authoritative,
            @ApiParam(value = "Is check configuration required to automatically create topic")
            @QueryParam("checkAllowAutoCreation") @DefaultValue("false") boolean checkAllowAutoCreation){
}

pulsar client admin: Topics#getPartitionedTopicMetadata

    PartitionedTopicMetadata getPartitionedTopicMetadata(String topic) throws PulsarAdminException;

Describe alternatives you've considered
I hope interfaces can be added.

    PartitionedTopicMetadata getPartitionedTopicMetadata(String topic, boolean checkAllowAutoCreation) throws PulsarAdminException;

Additional context
Original issue: streamnative/pulsar-flink#398

@shibd shibd added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Sep 4, 2021
@codelipenghui
Copy link
Contributor

@shibd Are you interested in pushing a fix? We should check the corresponding permissions(PolicyName.PARTITION, PolicyOperation.WRITE) if checkAllowAutoCreation is set to true.

@shibd
Copy link
Member Author

shibd commented Sep 6, 2021

@codelipenghui Ok, I'll try to fix it.

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

The issue had no activity for 30 days, mark with Stale label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

No branches or pull requests

2 participants