BC Breaks

[norkunas]

API Platform version(s) affected: 4.1.17

Description
Not sure when and where, but now some tests fail:

--- Expected
+++ Actual
@@ @@
         '@type' => 'CompanyLeadPreference'
         'industries' => Array (
-            0 => '/api/industries/01936891-9...'
+            0 => 'http://localhost/api/industries/01936891-9...'
         )
         'markets' => Array (
-            0 => '/api/markets/01934ee1-5083...'
+            0 => 'http://localhost/api/markets/01934ee1-5083...'
         )

Here we have an intermediate resource which is not api resource, but the skill resource has apiresource definition:

--- Expected
+++ Actual
@@ @@
        
             '@type' => 'CompanySkill'
             'skill' => Array (
                 '@type' => 'Skill'
-                '@id' => '/api/skills/01935232-6f05-7e2...fe23e1'
                 'id' => '01935232-6f05-7e2e-b4f6-943d3dfe23e1'

and not sure about this:

Failed asserting that '{\n
    "@context": "/api/contexts/Error",\n
    "@id": "/api/errors/403",\n
    "@type": "hydra:Error",\n
    "title": "An error occurred",\n
    "detail": "Access Denied. The user doesn't have ROLE_ADMIN.",\n
    "status": 403,\n
    "type": "/errors/403",\n
    "description": "Access Denied. The user doesn't have ROLE_ADMIN.",\n
    "hydra:description": "Access Denied. The user doesn't have ROLE_ADMIN.",\n
    "hydra:title": "An error occurred"\n
}' matches JSON string "{
  "@context": "/api/contexts/Error",
  "@id": "/api/errors/403",
  "@type": "hydra:Error",
  "title": "An error occurred",
  "description": "Access Denied.",
  "detail": "Access Denied.",
  "status": 403,
  "type": "/errors/403",
  "hydra:title": "An error occurred",
  "hydra:description": "Access Denied."
}".

How to reproduce

Possible Solution

Additional Context

[norkunas]

Ok so the last one because of upgrade to Symfony 7.3..

[soyuka]

is it 34a0d54 ? are you using an absolute url for IRI generation?

[norkunas]

is it 34a0d54 ?

could be.. i use #[ApiProperty(genId: false])

are you using an absolute url for IRI generation?

i don't manage it. it was previously properly generating relative uri, i don't force absolute url anywhere.

[soyuka]

I'd assume Skill has a genId: false? therefore remove genId to bring back your @id? Could you send me some details about your resource declaration (even a substract?)

[norkunas]

@soyuka

#[ApiResource(
    operations: [
        new GetCollection(),
        new Get(),
    ],
)]
class Skill {}

// no api resource definition
class CompanySkill {}

#[ApiResource(
    operations: [
        new GetCollection(),
        new Post(),
        new BulkUpdate(),
        new BulkDelete(),
        new Get(),
        new Put(),
        new Delete(),
    ],
)]
class Company {
    #[ApiProperty(genId: false)]
    private Collection $skills;
}

[soyuka]

Nice thanks I'll take a look asap