From 0fa4b45e490238e7210009e4a1278e7a1c98d0c2 Mon Sep 17 00:00:00 2001 From: Sohel Amin Date: Mon, 28 May 2018 10:58:55 +0600 Subject: [PATCH] Improve duplicate check code --- src/Analyzers/DuplicateAnalyzer.php | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/Analyzers/DuplicateAnalyzer.php b/src/Analyzers/DuplicateAnalyzer.php index 3b4c62d..26cf977 100644 --- a/src/Analyzers/DuplicateAnalyzer.php +++ b/src/Analyzers/DuplicateAnalyzer.php @@ -71,19 +71,16 @@ protected function processLines(SplFileObject $file) $trimLine = trim($line); $lineNo = ($file->key() + 1); - if ($foundIndex = array_search($trimLine, array_column($lines, 'code'))) { - $foundLineNo = $lines[$foundIndex]['lineNo']; + if (isset($lines[$trimLine])) { + $foundLineNo = $lines[$trimLine]; if (!in_array($foundLineNo, $duplicates)) { $duplicates[] = $foundLineNo; } - $duplicates[] = $lineNo; - } - if (strlen($trimLine) > 3) { - $lines[] = [ - 'lineNo' => $lineNo, - 'code' => $trimLine, - ]; + $duplicates[] = $lineNo; + } else if (strlen($trimLine) > 3) { + // Non duplicate first line + $lines[$trimLine] = $lineNo; } }