Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Auto detect framework upgrade's dependency on a specific binary version #6281

Open
movekevin opened this issue Jan 23, 2023 · 3 comments
Assignees
Labels
bug Something isn't working release-tooling Issues related to release CLI stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@movekevin
Copy link
Contributor

🐛 Bug

Changes in Move that require a framework upgrade might have dependencies on changes in the VM. We want to automate discovering this dependency if possible to avoid cases where we do a framework upgrade without the VM changes being rolled out first.

Having tests that cover specific features might help but in many cases, these tests might be skipped or don't have coverage of all possible cases. It'd still be helpful to have auto detection when we attempt a release where there's a dependency on a binary that is not yet released to sufficient validator nodes.

@movekevin movekevin added the bug Something isn't working label Jan 23, 2023
@movekevin movekevin changed the title [Bug] [Bug] Auto detect framework upgrade's dependency on a specific binary version Jan 23, 2023
@movekevin movekevin added the release-tooling Issues related to release CLI label Jan 27, 2023
@runtian-zhou
Copy link
Contributor

This is much harder to do because we don't have a way to publicly query the binary version a node is running on. Plus it could vary from node to node so it's hard to get some real signal on top of public tool.

@lbmeiyi lbmeiyi moved this from 🆕 New to 📋 Backlog in Move Language and Runtime Feb 16, 2023
@lbmeiyi lbmeiyi moved this from 📋 Backlog to 🏗 In progress in Move Language and Runtime Feb 16, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Mar 20, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Move Language and Runtime Apr 5, 2023
@movekevin movekevin reopened this Apr 5, 2023
@github-project-automation github-project-automation bot moved this from ✅ Done to 📋 Backlog in Move Language and Runtime Apr 5, 2023
@movekevin movekevin removed the Stale label Apr 5, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label May 21, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Move Language and Runtime Jun 5, 2023
@brmataptos brmataptos added stale-exempt Prevents issues from being automatically marked and closed as stale and removed Stale labels Oct 31, 2024
@brmataptos brmataptos reopened this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release-tooling Issues related to release CLI stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Archived in project
Development

No branches or pull requests

3 participants