Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: github.com/liamg/jfather package doesn't decode unicode characters #8233

Open
DmitriyLewen opened this issue Jan 13, 2025 Discussed in #8230 · 0 comments
Open

bug: github.com/liamg/jfather package doesn't decode unicode characters #8233

DmitriyLewen opened this issue Jan 13, 2025 Discussed in #8230 · 0 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@DmitriyLewen
Copy link
Contributor

Description

We use github.com/liamg/jfather package to get line numbers for json files.
But it returns error for unicode characters:

➜ cat composer.lock| grep descr
      "description": "Erg\u041f\u0440nzung",
....
2025-01-13T13:37:02+06:00	DEBUG	Walk error	file_path="composer.lock" err="parse error: failed to parse composer.lock: decode error: error at line 17, column 33: invalid unicode character 'invalid syntax'"

This happens because strconv.Unquote returns an error if the string doesn't contain quotes.

Discussed in #8230

@DmitriyLewen DmitriyLewen added the kind/bug Categorizes issue or PR as related to a bug. label Jan 13, 2025
@DmitriyLewen DmitriyLewen self-assigned this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant