Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

测试用例没跑通 #7

Closed
afc163 opened this issue Dec 10, 2012 · 4 comments
Closed

测试用例没跑通 #7

afc163 opened this issue Dec 10, 2012 · 4 comments
Assignees
Milestone

Comments

@afc163
Copy link
Member

afc163 commented Dec 10, 2012

http://aralejs.org/switchable/tests/runner.html

有全局变量泄露。

@ghost ghost assigned leoner Dec 10, 2012
@popomore
Copy link
Member

看了下好像是这行代码的问题,跟 jq 事件有关?

https://github.com/aralejs/switchable/blob/master/src/plugins/autoplay.js#L67

@afc163
Copy link
Member Author

afc163 commented Jan 4, 2013

绑在 document 上就没有泄露了。

@lizzie
Copy link
Member

lizzie commented Jul 16, 2013

现在已经全部通过, 这个 issue 先关闭

@lizzie lizzie closed this as completed Jul 16, 2013
@afc163
Copy link
Member Author

afc163 commented Jul 16, 2013

因为去掉了全局变量检测才跑过的,后续要试试绑定在 document 上来避免全局变量。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants