Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator setting the pods' RestartPolicy cause gitops tools to fail health checks #789

Open
sarahhenkens opened this issue Sep 20, 2021 · 1 comment

Comments

@sarahhenkens
Copy link

The operator starts all its server pod with the RestartPolicy set to Never. This causes ArgoCD to fail to report it as running.

RestartPolicy: core.RestartPolicyNever,

Can this be changed to Always and let the pod automatically restart itself on failure?

Related ticket with repro steps: argoproj/argo-cd#7259

@ajanikow
Copy link
Collaborator

Hello!

We do not want to allow Pod restarts, full lifecycle is managed by Operator (Operator recreate pod, takes care about shards).

It is also used in Graceful shutdowns, when we send request thru API. This logic will change (to send Delete + handle it in finalizers), but ETA is next year.

Best Regards,
Adam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants