-
-
Notifications
You must be signed in to change notification settings - Fork 150
Comparing changes
Open a pull request
base repository: arduino/arduino-create-agent
base: 1.7.0-rc3
head repository: arduino/arduino-create-agent
compare: main
- 14 commits
- 46 files changed
- 4 contributors
Commits on Jan 21, 2025
-
fix(serialport): data race on the
isClosing
bool status of the seri……al port (#1009) * fix: use atomic boolean for thread-safe isClosing flag
Configuration menu - View commit details
-
Copy full SHA for 1b94ccc - Browse repository at this point
Copy the full SHA 1b94cccView commit details
Commits on Mar 2, 2025
-
Use canonical github/setup-licensed action in dependencies license ch…
…eck workflow This GitHub Actions action is used by the dependencies license check workflow to install the "Licensed" tool in the runner workspace. At the time the workflow was developed, the action was owned by GitHub user `jonabc`, and so the action was referenced as `jonabc/setup-licensed` in the workflow. Since that time, the action was transferred to the `github` GitHub organization. Making things more confusing is the fact that GitHub user `jonabc` now has a development fork of the `github/setup-licensed` repository, meaning that the redirect GitHub provides from the old to the new repository after a transfer does not exist for this action. This resulted in the workflow referencing an outdated copy of the action not intended for production use. The workflow is hereby updated to use the canonical "github/setup-licensed" action.
Configuration menu - View commit details
-
Copy full SHA for f0857f0 - Browse repository at this point
Copy the full SHA f0857f0View commit details -
Use latest version of "github/setup-licensed" action
The "github/setup-licensed" action is used by the dependencies license check workflow to install the "Licensed" tool in the runner machine. Previously the `v1` major version ref of the action was specified in the workflow. This approach is used in order to allow the workflow to automatically always use the latest minor version of the action, only requiring the project maintainers to perform a bump of the action after each major version release. In a competently maintained action project, the major version ref will be updated after each release within that major version series so that it always points to the latest release version. Unfortunately that was not done by the "github/setup-licensed" action maintainers. This means that the use of the `v1` ref in the workflow causes an outdated version of the action to be used. This has been reported to the action maintainers, but unfortunately instead of fixing the problem they archived the repository, so there is no hope of it being resolved. The solution is to replace the major version ref with the ref for the latest release tag. This won't result in an increased maintenance burden because the action repository is archived and thus there won't be any bumps.
Configuration menu - View commit details
-
Copy full SHA for 2bf6e95 - Browse repository at this point
Copy the full SHA 2bf6e95View commit details -
Use maintained fork of "setup-licensed" action in dependencies licens…
…e check workflow This GitHub Actions action is used by the dependencies license check workflow to install the "Licensed" tool in the runner workspace. The action has a convoluted history: the repository was originally owned by GitHub user `jonabc`. It was later transferred to the `github` organization. Then GitHub abandoned the project, archiving the repository. The `licensee` organization has now created a hard fork of the action, which is recommended in the readme of the `github/setup-licensed` repository. The `licensee` organization has also taken over the management of the "Licensed" tool, and their `licensee` Ruby gem is a significant dependency of "Licensed". So they will be best equipped to maintain the action going forward. The workflow is hereby updated to use the canonical "licensee/setup-licensed" action. The "licensee/setup-licensed" action maintainers have not provided a major version ref, so it is necessary to pin the action to the latest release tag.
Configuration menu - View commit details
-
Copy full SHA for 26bd566 - Browse repository at this point
Copy the full SHA 26bd566View commit details -
Configure dependency license check workflows to allow "Licensed" inst…
…all via Gem The "Licensed" tool is used to check the project's compatibility with the licensing of its dependencies. This tool is installed by the dependency license check GitHub Actions workflow using the `licensee/setup-licensed` GitHub Actions action. This action attempts the installation according to the following procedure: 1. Install the Ruby gem. 2. If gem installation fails, install the pre-built executable from the GitHub release asset in the `licensee/licensed` repo. Previously, the first of these installation methods was failing: ```text /usr/bin/gem install licensed -v 3.9.1 ERROR: While executing gem ... (Gem::FilePermissionError) You don't have write permissions for the /var/lib/gems/3.2.0 directory. /usr/lib/ruby/vendor_ruby/rubygems/installer.rb:713:in `verify_gem_home' /usr/lib/ruby/vendor_ruby/rubygems/installer.rb:903:in `pre_install_checks' /usr/lib/ruby/vendor_ruby/rubygems/installer.rb:303:in `install' /usr/lib/ruby/vendor_ruby/rubygems/resolver/specification.rb:105:in `install' /usr/lib/ruby/vendor_ruby/rubygems/request_set.rb:195:in `block in install' /usr/lib/ruby/vendor_ruby/rubygems/request_set.rb:183:in `each' /usr/lib/ruby/vendor_ruby/rubygems/request_set.rb:183:in `install' /usr/lib/ruby/vendor_ruby/rubygems/commands/install_command.rb:215:in `install_gem' /usr/lib/ruby/vendor_ruby/rubygems/commands/install_command.rb:231:in `block in install_gems' /usr/lib/ruby/vendor_ruby/rubygems/commands/install_command.rb:224:in `each' /usr/lib/ruby/vendor_ruby/rubygems/commands/install_command.rb:224:in `install_gems' /usr/lib/ruby/vendor_ruby/rubygems/commands/install_command.rb:170:in `execute' /usr/lib/ruby/vendor_ruby/rubygems/command.rb:328:in `invoke_with_build_args' /usr/lib/ruby/vendor_ruby/rubygems/command_manager.rb:253:in `invoke_command' /usr/lib/ruby/vendor_ruby/rubygems/command_manager.rb:193:in `process_args' /usr/lib/ruby/vendor_ruby/rubygems/command_manager.rb:151:in `run' /usr/lib/ruby/vendor_ruby/rubygems/gem_runner.rb:52:in `run' /usr/bin/gem:12:in `<main>' gem installation was not successful ``` So it falls back on the second installation method. That method works fine when using a version of "Licensed" <4.0.0. However, starting from version 4.0.0, pre-built executable are no longer provided, so the only available installation method for modern versions of "Licensed" is via the Ruby gem. The gem failure can be avoided by setting up an accessible installation of Ruby in the runner machine, which is accomplished using the "ruby/setup-ruby" action in a step preceding the `licensee/setup-licensed` step in the workflow.
Configuration menu - View commit details
-
Copy full SHA for 1f89384 - Browse repository at this point
Copy the full SHA 1f89384View commit details -
Bump "Licensed" version in dependencies license check workflow
The version of the "Licensed" tool for use in the GitHub Actions workflow is defined via the "licensee/setup-licensed" action's `version` input. Previously the action was configured to install version 3.x of the action. That version is significantly outdated. The workflow is hereby updated to use the latest version of Licensed.
Configuration menu - View commit details
-
Copy full SHA for b2e28c0 - Browse repository at this point
Copy the full SHA b2e28c0View commit details -
Remove trailing space from dependency license metadata
The dependency license metadata is generated by the "Licensed" tool. Previous versions of this tool added a trailing space on the `summary` key. Although trailing whitespace in human produced content is not permitted, machine generated content is used as-is, and so these trailing spaces were left in the metadata files. It seems that the defect in the "Licensed" tool that caused the trailing space was fixed in a recent version because it is now absent in the metadata files produced by the tool. The metadata files are hereby updated to use the format of the version of the "Licensed" tool currently in use.
Configuration menu - View commit details
-
Copy full SHA for 0fae57e - Browse repository at this point
Copy the full SHA 0fae57eView commit details -
Add generated YAML document end markers to dependency license metadat…
…a cache The dependency license metadata is generated by the "Licensed" tool. The version of the tool now in use adds YAML document end markers to some metadata files, which were not present in the files generated by the tool at the time the cache was established. I don't know why it adds these markers to only some of the metadata files, but they are valid (though optional so the files without are also correct) and machine generated content is used as-is. The metadata files are hereby updated to use the format produced by the version of the "Licensed" tool currently in use.
Configuration menu - View commit details
-
Copy full SHA for bfab101 - Browse repository at this point
Copy the full SHA bfab101View commit details
Commits on Mar 19, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 5fcb7c4 - Browse repository at this point
Copy the full SHA 5fcb7c4View commit details
Commits on Mar 26, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 5063c6c - Browse repository at this point
Copy the full SHA 5063c6cView commit details
Commits on Mar 27, 2025
-
fix: allow to specify custom
signatureKey
in theconfig.ini
(#1024)* make the signaturePubKey overwritable * Add debug logging for signature key parsing and handle newline escape sequences * Add MustParseRsaPublicKey function for parsing PEM formatted public keys * Remove debug print statement for signature key and fix comment typo in key parsing logic * Add error logging for command verification and update comment for public key usage * refactor(main.go) remove unnecessary print statement in parseIni function * refactor(utilities): improve formatting in ParseRsaPublicKey function * style(tools): align field declarations for improved readability --------- Co-authored-by: Luca Rinaldi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 901728d - Browse repository at this point
Copy the full SHA 901728dView commit details
Commits on Mar 28, 2025
-
fix: update go.bug.st/serial to v1.6.4 to fix windows issue (#1027)
* fix: update go.bug.st/serial to v1.6.4 * Updated license cache --------- Co-authored-by: Cristian Maglie <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 87f097b - Browse repository at this point
Copy the full SHA 87f097bView commit details
Commits on Apr 1, 2025
-
Configuration menu - View commit details
-
Copy full SHA for b717430 - Browse repository at this point
Copy the full SHA b717430View commit details
Commits on Apr 24, 2025
-
fix: Serial Monitor corrupted output in some rare cases (#1032)
* Synchronize multiple open commands coming together. * Allow re-opening of already opened ports * Renamed mutex var and added comment * Error out if baudrate and buftype of already opened port do not match
Configuration menu - View commit details
-
Copy full SHA for e7ea376 - Browse repository at this point
Copy the full SHA e7ea376View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.7.0-rc3...main