coccinelle: irq_lock.cocci: Update script

* Provide a single liner description at top using `///`
  comments. This one liner is displayed when using `--verbose`
  mode of coccicheck.

* Specify Condidence level property adhering to coccinelle.rst
  section "Proposing new semantic patches".

* Add virtual patch rule to handle the patch case when coccicheck
  is supplied with `--mode=patch` option.

* Add `depends on !(file in "ext")` to ignore reports from `ext/`
  directory.

* Simplify rule to use disjunctions and use "exists" to match any
  available control path.

Suggested-by: Julia Lawall <[email protected]>
Signed-off-by: Himanshu Jha <[email protected]>

Author: himanshujha199640

scripts/coccinelle/irq_lock.cocci

@@ -1,47 +1,45 @@
+/// Use unsigned int as the return value for irq_lock()
+///
+// Confidence: High
 // Copyright (c) 2017 Intel Corporation
 //
 // SPDX-License-Identifier: Apache-2.0
 
-@find@
+virtual patch
+
+@find depends on !(file in "ext")@
 type T;
-position p;
 identifier i;
+typedef uint32_t,u32_t;
 @@
 
-T@p i = irq_lock();
-
-@script:python raise_error@
-t << find.T;
-@@
-if t in ["uint32_t", "unsigned int", "u32_t"]:
-   cocci.include_match(False)
-
-@replacement@
-type find.T;
-position find.p;
-@@
-- T@p
+(
+ uint32_t i = irq_lock();
+|
+ unsigned int i = irq_lock();
+|
+ u32_t i = irq_lock();
+|
+- T
 + unsigned int
+  i = irq_lock();
+)
 
-@find2@
+@find2 depends on !(file in "ext") exists@
 type T;
-position p;
 identifier i;
 @@
 
-T@p i;
-...
-i = irq_lock();
-
-@script:python raise_error2@
-t << find2.T;
-@@
-if t in ["uint32_t", "unsigned int", "u32_t"]:
-   cocci.include_match(False)
-
-@replacement2@
-type find2.T;
-identifier find2.i;
-@@
--  T i;
-+  unsigned int i;
+(
+ uint32_t i;
+|
+ unsigned int i;
+|
+ u32_t i;
+|
+- T
++ unsigned int
+  i;
+  ...
+  i = irq_lock();
+)