Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates per User Feedback #158

Closed
chelma opened this issue Jan 19, 2024 · 3 comments
Closed

Some updates per User Feedback #158

chelma opened this issue Jan 19, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@chelma
Copy link
Collaborator

chelma commented Jan 19, 2024

Description

A conversation with some users indicated a couple pain points we can easily address:

  • The README uses an --expected-traffic of 1 Gbps, which results in a large installation. We should use a smaller number for that example.
  • Users expect cluster-destroy to destroy everything and are surprised when it doesn't. It is un-obvious to them that they need to supply the --destroy-everything flag to get that behavior. Per @awick suggestion, we can address by adding a --retain-traffic-data flag and requiring users to supply one of the two flags.
@chelma chelma added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 19, 2024
@chelma chelma self-assigned this Jan 19, 2024
@chelma
Copy link
Collaborator Author

chelma commented Jan 22, 2024

Code to address merged; resolving.

@chelma chelma closed this as completed Jan 22, 2024
@chelma chelma reopened this Jan 22, 2024
@chelma
Copy link
Collaborator Author

chelma commented Jan 22, 2024

Oops - code hasn't been reviewed/merged yet. Reopening 😄

@chelma
Copy link
Collaborator Author

chelma commented Jan 22, 2024

Ok - code has been approved/merged now. Resolving again. 😉

@chelma chelma closed this as completed Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant