Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Commit 5fcce84

Browse files
Workaround to fix #235 (add placeholder inside node_modules)
1 parent 1f21689 commit 5fcce84

File tree

11 files changed

+63
-6
lines changed

11 files changed

+63
-6
lines changed

.gitignore

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,13 @@ npm-debug.log
3434
# files with that name (https://github.com/npm/npm/issues/1862). So, each template instead has a template_gitignore
3535
# file which gets renamed after the files are copied. And so any files that need to be excluded in the source
3636
# repo have to be excluded here.
37-
/templates/*/node_modules/
37+
38+
# Note that we need to exclude node_modules/** (i.e., subdirs, not the whole of node_modules) because we do need to
39+
# include the _placeholder.txt files, and can't do that using gitignore exclusion because developers aren't promoted to
40+
# commit files included that way. This is all a workaround for Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
41+
/templates/*/node_modules/**
3842
/templates/*/wwwroot/dist/
3943
.vscode/
44+
45+
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
46+
!/templates/*/node_modules/_placeholder.txt

templates/Angular2Spa/node_modules/_placeholder.txt

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/Angular2Spa/template_gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,12 @@ ClientBin/
184184
*.dbproj.schemaview
185185
*.pfx
186186
*.publishsettings
187-
node_modules/
188187
orleans.codegen.cs
189188

189+
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
190+
/node_modules/**
191+
!/node_modules/_placeholder.txt
192+
190193
# RIA/Silverlight projects
191194
Generated_Code/
192195

templates/KnockoutSpa/node_modules/_placeholder.txt

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/KnockoutSpa/template_gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,12 @@ ClientBin/
184184
*.dbproj.schemaview
185185
*.pfx
186186
*.publishsettings
187-
node_modules/
188187
orleans.codegen.cs
189188

189+
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
190+
/node_modules/**
191+
!/node_modules/_placeholder.txt
192+
190193
# RIA/Silverlight projects
191194
Generated_Code/
192195

templates/ReactReduxSpa/node_modules/_placeholder.txt

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/ReactReduxSpa/template_gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,12 @@ ClientBin/
184184
*.dbproj.schemaview
185185
*.pfx
186186
*.publishsettings
187-
node_modules/
188187
orleans.codegen.cs
189188

189+
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
190+
/node_modules/**
191+
!/node_modules/_placeholder.txt
192+
190193
# RIA/Silverlight projects
191194
Generated_Code/
192195

templates/ReactSpa/node_modules/_placeholder.txt

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/ReactSpa/template_gitignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,12 @@ ClientBin/
184184
*.dbproj.schemaview
185185
*.pfx
186186
*.publishsettings
187-
node_modules/
188187
orleans.codegen.cs
189188

189+
# Workaround for https://github.com/aspnet/JavaScriptServices/issues/235
190+
/node_modules/**
191+
!/node_modules/_placeholder.txt
192+
190193
# RIA/Silverlight projects
191194
Generated_Code/
192195

templates/WebApplicationBasic/node_modules/_placeholder.txt

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)