From be2ba2bd6c2fbcdf10954956977fa6f1e499d3a2 Mon Sep 17 00:00:00 2001 From: Mark Pieszak Date: Wed, 3 Aug 2016 13:02:08 -0400 Subject: [PATCH 1/7] chore(github): Add Github templates --- .github/ISSUE_TEMPLATE.md | 46 ++++++++++++++++++++++++++++++++ .github/PULL_REQUEST_TEMPLATE.md | 32 ++++++++++++++++++++++ 2 files changed, 78 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE.md create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 00000000..f27ce268 --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,46 @@ +**Note: for support questions, please use one of these channels:** https://github.com/aspnet/Home/blob/dev/CONTRIBUTING.md#filing-issues. This repository's issues are reserved for feature requests and bug reports. + +* **I'm submitting a ...** +- [ ] bug report +- [ ] feature request +- [ ] support request => Please do not submit support request here, see note at the top of this template. + +* **What Modules or Template are related to this Issue?** +- [ ] AngularServices +- [ ] NodeServices +- [ ] ReactServices +- [ ] SpaServices +- [ ] Angular2 Spa +- [ ] Knockout Spa +- [ ] ReactRedux Spa +- [ ] React Spa + + +* **Do you want to request a *feature* or report a *bug*?** + + + +* **What is the current behavior?** + + + +* **If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem** by creating a github repo. + + + +* **What is the expected behavior?** + + + +* **What is the motivation / use case for changing the behavior?** + + + +* **Please tell us about your environment:** + +- Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX ] +- OS: [all | Mac OS X | Windows | Linux ] +- Platform: [all | NodeJs | Java | PHP | .Net | Ruby] + + +* **Other information** (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..733500d4 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,32 @@ +* **Please check if the PR fulfills these requirements** +- [ ] The commit message follows our guidelines: https://github.com/aspnet/Home/blob/dev/CONTRIBUTING.md#contributing-code-and-content +- [ ] Tests for the changes have been added (for bug fixes / features) +- [ ] Docs have been added / updated (for bug fixes / features) + +* **What Modules or Template are related to this pull-request?** +- [ ] AngularServices +- [ ] NodeServices +- [ ] ReactServices +- [ ] SpaServices +- [ ] Angular2 Spa +- [ ] Knockout Spa +- [ ] ReactRedux Spa +- [ ] React Spa + +* **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) +remove unused proxy imports from some test files + + +* **What is the current behavior?** (You can also link to an open issue here) + + + +* **What is the new behavior (if this is a feature change)?** + + + +* **Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?) +No + + +* **Other information**: From 3f3a9efe03e1207e2cdf971d972aab72b563c6aa Mon Sep 17 00:00:00 2001 From: Mark Pieszak Date: Wed, 3 Aug 2016 13:04:50 -0400 Subject: [PATCH 2/7] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 733500d4..0f665ac0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -14,7 +14,6 @@ - [ ] React Spa * **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) -remove unused proxy imports from some test files * **What is the current behavior?** (You can also link to an open issue here) From 3b58e2ac1a2411f40d41bc9d04e8563aa9daa95b Mon Sep 17 00:00:00 2001 From: Mark Pieszak Date: Thu, 4 Aug 2016 09:53:37 -0400 Subject: [PATCH 3/7] Cleanup issue template --- .github/ISSUE_TEMPLATE.md | 27 +++------------------------ 1 file changed, 3 insertions(+), 24 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index f27ce268..aefd38a0 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,46 +1,25 @@ -**Note: for support questions, please use one of these channels:** https://github.com/aspnet/Home/blob/dev/CONTRIBUTING.md#filing-issues. This repository's issues are reserved for feature requests and bug reports. - * **I'm submitting a ...** - [ ] bug report - [ ] feature request -- [ ] support request => Please do not submit support request here, see note at the top of this template. -* **What Modules or Template are related to this Issue?** +* **What Module(s) or Template are related to this Issue?** - [ ] AngularServices - [ ] NodeServices - [ ] ReactServices - [ ] SpaServices + - [ ] Angular2 Spa - [ ] Knockout Spa - [ ] ReactRedux Spa - [ ] React Spa -* **Do you want to request a *feature* or report a *bug*?** - - - * **What is the current behavior?** - - - -* **If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem** by creating a github repo. - - +* * **What is the expected behavior?** -* **What is the motivation / use case for changing the behavior?** - - - -* **Please tell us about your environment:** - -- Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX ] -- OS: [all | Mac OS X | Windows | Linux ] -- Platform: [all | NodeJs | Java | PHP | .Net | Ruby] -* **Other information** (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc) From 8b9af99f4b25079a4bcacb7f2a059f1fca26b578 Mon Sep 17 00:00:00 2001 From: Mark Pieszak Date: Thu, 4 Aug 2016 09:54:32 -0400 Subject: [PATCH 4/7] Update ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index aefd38a0..6d7f7c27 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -7,7 +7,6 @@ - [ ] NodeServices - [ ] ReactServices - [ ] SpaServices - - [ ] Angular2 Spa - [ ] Knockout Spa - [ ] ReactRedux Spa @@ -15,7 +14,7 @@ * **What is the current behavior?** -* + * **What is the expected behavior?** From ba93b074b1d4836bef5875d0d3b760f4389936da Mon Sep 17 00:00:00 2001 From: Mark Pieszak Date: Thu, 4 Aug 2016 09:58:34 -0400 Subject: [PATCH 5/7] Update ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 6d7f7c27..f1c871b5 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,22 +1,16 @@ -* **I'm submitting a ...** -- [ ] bug report -- [ ] feature request - -* **What Module(s) or Template are related to this Issue?** +* **Is this issue involving a Module(s)?** - [ ] AngularServices - [ ] NodeServices - [ ] ReactServices - [ ] SpaServices + +* **Is this issue involving a Template (if any)?** * - [ ] Angular2 Spa - [ ] Knockout Spa - [ ] ReactRedux Spa - [ ] React Spa - -* **What is the current behavior?** - - -* **What is the expected behavior?** +* **Please describe the issue in as much detail as you can:** From 6abf94903fea945218e404b7f5619d703c02e681 Mon Sep 17 00:00:00 2001 From: Mark Pieszak Date: Thu, 4 Aug 2016 09:59:57 -0400 Subject: [PATCH 6/7] Update ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index f1c871b5..6eaa3aee 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,10 +1,10 @@ -* **Is this issue involving a Module(s)?** +* **Is this JavaScriptServices issue involving a Module(s)?** - [ ] AngularServices - [ ] NodeServices - [ ] ReactServices - [ ] SpaServices -* **Is this issue involving a Template (if any)?** * +* **Is this issue involving one of the Templates?** * - [ ] Angular2 Spa - [ ] Knockout Spa - [ ] ReactRedux Spa From e873d5f3d8bb0fea4ff9a996f826cdb2694b5f77 Mon Sep 17 00:00:00 2001 From: Mark Pieszak Date: Thu, 4 Aug 2016 10:02:45 -0400 Subject: [PATCH 7/7] Clean-up PR template --- .github/PULL_REQUEST_TEMPLATE.md | 22 +++------------------- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0f665ac0..743256cb 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,13 +1,10 @@ -* **Please check if the PR fulfills these requirements** -- [ ] The commit message follows our guidelines: https://github.com/aspnet/Home/blob/dev/CONTRIBUTING.md#contributing-code-and-content -- [ ] Tests for the changes have been added (for bug fixes / features) -- [ ] Docs have been added / updated (for bug fixes / features) - -* **What Modules or Template are related to this pull-request?** +* **Is this PR involving a Module(s)?** - [ ] AngularServices - [ ] NodeServices - [ ] ReactServices - [ ] SpaServices + +* **Is this PR involving one of the Templates?** * - [ ] Angular2 Spa - [ ] Knockout Spa - [ ] ReactRedux Spa @@ -15,17 +12,4 @@ * **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) - -* **What is the current behavior?** (You can also link to an open issue here) - - - -* **What is the new behavior (if this is a feature change)?** - - - -* **Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?) -No - - * **Other information**: