-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't install packages from private PYPI source since v0.5.15 #11501
Comments
I'm not sure what could have caused this. Can you do a HEAD request with curl? If you do Can you share |
Yes, it works.
|
The only relevant change looks like #10227 here's the full enumeration of changes 0.5.14...0.5.15 |
@seanmonstar sorry to ping, but it seems like this was a change from reqwest 0.12.9 -> 0.12.12 — perhaps something will stand out to you? |
Sort of suspicious of seanmonstar/reqwest#2503 (there aren't many changes to pick from). @Remalloc could you test one of the binaries from https://github.com/astral-sh/uv/actions/runs/13332583535?pr=11512 (at the bottom) and see if it resolves your problem? |
Still have problem. |
Interesting, thanks for checking — that would rule out the reqwest upgrade. My next best guess was #10310 though it seems dubious cc @BurntSushi This would be via uv/crates/uv-client/src/httpcache/mod.rs Lines 521 to 539 in 5c0fdfd
uv/crates/uv-client/src/httpcache/mod.rs Lines 1377 to 1393 in 5c0fdfd
which I think are ruled out by this being a "fresh" request ( uv/crates/uv-client/src/cached_client.rs Lines 276 to 281 in a1a4d82
instead of uv/crates/uv-client/src/cached_client.rs Lines 272 to 274 in a1a4d82
which would invoke the referenced jiff code. Perhaps there's something I'm missing related to the range request path? I didn't dig into that yet. Unfortunately, I'm at a bit of a loss. We'd need to add more verbose request logs to understand what we're sending. What kind of PyPI server are you running? Can you get server-side logs about why the request was invalid or about the content of the requests? |
Just poking in here, sometimes the response body will include more details about why the request was bad. I didn't see it in any of the traces. |
I can't check service log because cloud service not provide, but I used Fiddler to capture all requests from uv and found a difference: The latest version(two requests):
uv 0.15.4(only one request)
So, the problem seems to be caused by the second HEAD request. |
Thanks for giving it a look Sean. I think we'll want to add logging of response bodies on failure — I'm not sure if we do that. cc @konstin Ah that's really helpful. In the previous version of uv we aren't downloading the wheel? That seems surprising. Does this reproduce if you use |
There is no problem in version 0.5.14. (--no-cache --reinstall-package datahub)
|
Interesting. That suggests the change is that in 0.5.15 we are using uv/crates/uv-client/src/registry_client.rs Line 710 in 748582e
Is this log present in 0.5.14? uv/crates/uv-client/src/registry_client.rs Line 772 in 748582e
Here's another pull request we can try #11539 — here we should fallback to Can you confirm what kind of PyPI server you're using? Is it provided by Alibaba Clloud? |
Yes, it is provided by Alibaba Cloud, but I don't know what type of PyPI server it is. #11539 new binary works now 😀 |
Nice, thanks for trying it. |
Thank you to all the devs for your efforts. I have also reported this issue to Alibaba Cloud, hoping they will support HEAD requests in the future. |
Thanks for your help! Still absolutely no clue how this regressed for you at some point. We must have changed the order of requests or something. |
Hello, I cloned this repository and found that the commit 7182a34 caused the issue. Do you have any ideas? |
Summary
When using version 0.5.14 or earlier, there was no issue. This issue affects all platforms.
Platform
Linux 6.5.0-44-generic x86_64 GNU/Linux
Version
0.5.15 ~ 0.5.31
Python version
Python 3.10 ~ 3.12
The text was updated successfully, but these errors were encountered: