#299 Improve form test

Author: Polleps

data-browser/src/components/forms/NewForm/useNewForm.ts

@@ -62,7 +62,7 @@ export const useNewForm = (
     store
       .renameSubject(oldSubject, defferedSubjectValue)
       .then(() => {
-        // setSubject(defferedSubjectValue);
+        setSubject(defferedSubjectValue);
       })
       .catch(e => setSubjectErr(e));
   }, [defferedSubjectValue, resource]);

data-browser/tests/e2e.spec.ts

@@ -422,12 +422,11 @@ test.describe('data-browser', async () => {
     await signIn(page);
     await page.locator(`${currentDriveTitle} > text=localhost`);
 
-    const dropdownId = await page
-      .locator(sideBarDriveSwitcher)
-      .getAttribute('aria-controls');
-
     await page.click(sideBarDriveSwitcher);
     // temp disable for trailing slash
+    // const dropdownId = await page
+    //   .locator(sideBarDriveSwitcher)
+    //   .getAttribute('aria-controls');
     // await page.click(`[id="${dropdownId}"] >> text=Atomic Data`);
     // await expect(page.locator(currentDriveTitle)).toHaveText('Atomic Data');
 
@@ -469,10 +468,15 @@ test.describe('data-browser', async () => {
     await signIn(page);
     await newDrive(page);
     await newResource('class', page);
+    const shortnameInput = '[data-test="input-shortname"]';
     // Try entering a wrong slug
-    await page.click('[data-test="input-shortname"]');
+    await page.click(shortnameInput);
     await page.keyboard.type('not valid');
     await expect(page.locator('text=Not a valid slug')).toBeVisible();
+    await page.locator(shortnameInput).fill('');
+    await page.keyboard.type('is-valid');
+    await expect(page.locator('text=Not a valid slug')).not.toBeVisible();
+
     // Add a new property
     await page.click(
       '[placeholder="Select a property or enter a property URL..."]',
@@ -491,6 +495,21 @@ test.describe('data-browser', async () => {
     await page.click('[data-test="input-recommends-add-resource"]');
     await page.locator('text=append').click();
     await expect(page.locator('text=https://atomicdata.dev')).not.toBeVisible();
+
+    // Try to save without a description
+    page.locator('button:has-text("Save")').click();
+    await expect(
+      page.locator(
+        'text=Property https://atomicdata.dev/properties/description missing',
+      ),
+    ).toBeVisible();
+
+    // Add a description
+    await page.click('textarea[name="yamdeContent"]');
+    await page.keyboard.type('This is a test class');
+    await page.click('button:has-text("Save")');
+
+    await expect(page.locator('text=Resource Saved')).toBeVisible();
   });
 
   test('sidebar subresource', async ({ page }) => {