From 3e374a8035bde7ca5ee944759e4da4fe3c17d454 Mon Sep 17 00:00:00 2001 From: Todd Austin Date: Mon, 9 Nov 2020 19:46:45 -0600 Subject: [PATCH] wip --- .github/workflows/tests.yml | 2 +- .../Controllers/Auth/AuthenticatedSessionControllerTest.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 0330025ef..1bd2ee68a 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest strategy: - fail-fast: true + fail-fast: false matrix: php: [7.3, 7.4, 8.0] laravel: [^6.0, ^7.0, ^8.0] diff --git a/tests/Http/Controllers/Auth/AuthenticatedSessionControllerTest.php b/tests/Http/Controllers/Auth/AuthenticatedSessionControllerTest.php index f5bdedac8..28e3d2f01 100644 --- a/tests/Http/Controllers/Auth/AuthenticatedSessionControllerTest.php +++ b/tests/Http/Controllers/Auth/AuthenticatedSessionControllerTest.php @@ -30,7 +30,7 @@ public function testLoginRequestWillValidateAnInvalidEmail(): void $response = $this->post('/canvas/login', [ 'email' => 'not-an-email', 'password' => 'password', - ]); + ])->assertSessionHas('errors'); $this->assertInstanceOf(ValidationException::class, $response->exception); } @@ -40,7 +40,7 @@ public function testLoginRequestWillValidateAnEmailNotInTheDatabase(): void $response = $this->post('/canvas/login', [ 'email' => 'email@example.com', 'password' => 'password', - ]); + ])->assertSessionHas('errors'); $this->assertInstanceOf(ValidationException::class, $response->exception); }