Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support import and export of account key in encrypted form using Web3 Secret Storage Definition #96

Open
cmjc opened this issue Feb 8, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@cmjc
Copy link
Contributor

cmjc commented Feb 8, 2023

Context

aut CLI's import account imports an unencrypted private key file. Autonity is better practice to have a private key in the ethereum encryted format ((https://ethereum.org/en/developers/docs/data-structures-and-encoding/web3-secret-storage/))

  • Should a command or option be added to import an ethereum encrypted keystore file?
  • Should as mirror, a command be added to export an account private key as an ethereum encrypted keystore file?
@cmjc cmjc added enhancement New feature or request question labels Feb 8, 2023
@dtebbs
Copy link
Contributor

dtebbs commented Feb 9, 2023

My take on this would be:

  • Should a command or option be added to import an ethereum encrypted keystore file?

No. This is just a matter of copying files. We should not bloat aut with this kind of thing - it should provide a core set of functionality which can be used to build higher level functionality.

  • Should as mirror, a command be added to export an account private key as an ethereum encrypted keystore file?

No. I'm not sure if the autonity or geth binary support this, but I don't think it should be trivial to do and I think it's fine for people to have to jump through hoops to do it. It's a candidate for an external tool or little blog post. Using autonity.py it's probably 3 lines fo python.

@cmjc cmjc self-assigned this Feb 10, 2023
@cmjc
Copy link
Contributor Author

cmjc commented Feb 10, 2023

OK. Simple is best.

(It's clear in aut account import-private-key --help it's encrypted format. No, you can't export the key - only list, import, new, update command-line options. Could be a blog post topic, yes.)

@dtebbs dtebbs removed the question label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants