Skip to content

Commit 7933eda

Browse files
committed
Add missing functionality to posixsubprocess
1 parent 8152e7e commit 7933eda

File tree

5 files changed

+250
-86
lines changed

5 files changed

+250
-86
lines changed

Lib/test/test_exception_hierarchy.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ def _make_map(s):
8181
return _map
8282
_map = _make_map(_pep_map)
8383

84-
@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
8584
def test_errno_mapping(self):
8685
# The OSError constructor maps errnos to subclasses
8786
# A sample test for the basic functionality

Lib/test/test_subprocess.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1614,8 +1614,6 @@ def test_file_not_found_includes_filename(self):
16141614
subprocess.call(['/opt/nonexistent_binary', 'with', 'some', 'args'])
16151615
self.assertEqual(c.exception.filename, '/opt/nonexistent_binary')
16161616

1617-
# TODO: RUSTPYTHON
1618-
@unittest.expectedFailure
16191617
@unittest.skipIf(mswindows, "behavior currently not supported on Windows")
16201618
def test_file_not_found_with_bad_cwd(self):
16211619
with self.assertRaises(FileNotFoundError) as c:
@@ -2033,8 +2031,6 @@ def test_start_new_session(self):
20332031
child_sid = int(output)
20342032
self.assertNotEqual(parent_sid, child_sid)
20352033

2036-
# TODO: RUSTPYTHON
2037-
@unittest.expectedFailure
20382034
@unittest.skipUnless(hasattr(os, 'setpgid') and hasattr(os, 'getpgid'),
20392035
'no setpgid or getpgid on platform')
20402036
def test_process_group_0(self):
@@ -2053,8 +2049,6 @@ def test_process_group_0(self):
20532049
child_pgid = int(output)
20542050
self.assertNotEqual(parent_pgid, child_pgid)
20552051

2056-
# TODO: RUSTPYTHON
2057-
@unittest.expectedFailure
20582052
@unittest.skipUnless(hasattr(os, 'setreuid'), 'no setreuid on platform')
20592053
def test_user(self):
20602054
# For code coverage of the user parameter. We don't care if we get a
@@ -2112,8 +2106,6 @@ def test_user_error(self):
21122106
with self.assertRaises(ValueError):
21132107
subprocess.check_call(ZERO_RETURN_CMD, user=65535)
21142108

2115-
# TODO: RUSTPYTHON, observed gids do not match expected gids
2116-
@unittest.expectedFailure
21172109
@unittest.skipUnless(hasattr(os, 'setregid'), 'no setregid() on platform')
21182110
def test_group(self):
21192111
gid = os.getegid()

0 commit comments

Comments
 (0)