Skip to content

Commit 82bb9c8

Browse files
committed
use version=2 for get requests
1 parent dd8768b commit 82bb9c8

File tree

4 files changed

+47
-4
lines changed

4 files changed

+47
-4
lines changed

Makefile

+10
Original file line numberDiff line numberDiff line change
@@ -148,3 +148,13 @@ download-ashwini-backup:
148148
copy-backup-to-vagrant:
149149
scp -P 2222 -i ~/.vagrant.d/insecure_private_key /tmp/abi-backup.sql [email protected]:/tmp/
150150
#######
151+
152+
restore-ashwini-dump:
153+
ifndef dumpFile
154+
@echo "Provde the dumpFile variable"
155+
exit 1
156+
else
157+
$(call _drop_db,avni_int_ashwini)
158+
$(call _build_db,avni_int_ashwini)
159+
psql -U bahmni_avni_admin -d avni_int_ashwini < $(dumpFile)
160+
endif

integration-data/src/test/java/org/bahmni_avni_integration/integration/data/util/FormatUtilTest.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,13 @@ public void toISODateString() {
1919
public void fromAvniDate() {
2020
Date date = FormatAndParseUtil.fromAvniDate("2020-05-25");
2121
assertNotNull(date);
22+
date = FormatAndParseUtil.fromAvniDate("2020-05-25T18:30:00.000Z");
23+
assertNotNull(date);
2224
}
2325

2426
@Test
2527
public void fromAvniDateTime() {
2628
Date date = FormatAndParseUtil.fromAvniDateTime("2021-01-14T08:11:29.012Z");
2729
assertNotNull(date);
2830
}
29-
}
31+
}

integrator/src/main/java/org/bahmni_avni_integration/client/AvniHttpClient.java

+7-3
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,17 @@ public class AvniHttpClient {
4242
private AuthenticationHelper helper;
4343

4444
public <T> ResponseEntity<T> get(String url, Map<String, String> queryParams, Class<T> returnType) {
45+
URI uri = makeGetUri(url, queryParams);
46+
return getResponseEntity(returnType, uri, HttpMethod.GET, null);
47+
}
48+
49+
URI makeGetUri(String url, Map<String, String> queryParams) {
4550
UriComponentsBuilder builder = UriComponentsBuilder.fromHttpUrl(apiUrl(url));
4651
for (var entry : queryParams.entrySet()) {
4752
builder.queryParam(entry.getKey(), entry.getValue());
4853
}
4954

50-
URI uri = builder.build().encode().toUri();
51-
return getResponseEntity(returnType, uri, HttpMethod.GET, null);
55+
return builder.build().encode().toUri();
5256
}
5357

5458
private <T> ResponseEntity<T> getResponseEntity(Class<T> returnType, URI uri, HttpMethod method, String json) {
@@ -129,6 +133,6 @@ public String fetchAuthToken() {
129133
}
130134

131135
private String apiUrl(String url) {
132-
return String.format("%s%s", AVNI_API_URL, url);
136+
return String.format("%s%s?version=2", AVNI_API_URL, url);
133137
}
134138
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
package org.bahmni_avni_integration.client;
2+
3+
import org.bahmni_avni_integration.AbstractIntegrationTest;
4+
import org.junit.jupiter.api.Test;
5+
import org.springframework.beans.factory.annotation.Autowired;
6+
import org.springframework.boot.test.context.SpringBootTest;
7+
8+
import java.net.URI;
9+
import java.util.HashMap;
10+
11+
import static org.junit.jupiter.api.Assertions.assertEquals;
12+
13+
@SpringBootTest
14+
class AvniHttpClientTest extends AbstractIntegrationTest {
15+
@Autowired
16+
private AvniHttpClient avniHttpClient;
17+
18+
@Test
19+
void makeGetUri() {
20+
HashMap<String, String> queryParams = new HashMap<>() {{
21+
put("foo", "bar");
22+
}};
23+
assertEquals("https://staging.avniproject.org/baz?version=2&foo=bar", avniHttpClient.makeGetUri("/baz", queryParams).toString());
24+
assertEquals("https://staging.avniproject.org?version=2&foo=bar", avniHttpClient.makeGetUri("", queryParams).toString());
25+
assertEquals("https://staging.avniproject.org/baz?version=2", avniHttpClient.makeGetUri("/baz", new HashMap<>()).toString());
26+
}
27+
}

0 commit comments

Comments
 (0)