From 767daefefaf4760ef04b5a49c08599aef576f411 Mon Sep 17 00:00:00 2001 From: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Date: Thu, 21 Aug 2025 04:22:17 +0000 Subject: [PATCH 1/7] test(credential-provider-sso): check tryNextLink=false in CredentialsProviderError --- packages/credential-provider-sso/src/fromSSO.spec.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/credential-provider-sso/src/fromSSO.spec.ts b/packages/credential-provider-sso/src/fromSSO.spec.ts index be949e78f3499..2655750a2242f 100644 --- a/packages/credential-provider-sso/src/fromSSO.spec.ts +++ b/packages/credential-provider-sso/src/fromSSO.spec.ts @@ -130,7 +130,8 @@ describe(fromSSO.name, () => { it.each(["ssoStartUrl", "ssoAccountId", "ssoRegion", "ssoRoleName"])("missing '%s'", async (key) => { const expectedError = new CredentialsProviderError( 'Incomplete configuration. The fromSSO() argument hash must include "ssoStartUrl",' + - ' "ssoAccountId", "ssoRegion", "ssoRoleName"' + ' "ssoAccountId", "ssoRegion", "ssoRoleName"', + { tryNextLink: false } ); try { await fromSSO({ ...mockSsoProfile, [key]: undefined })(); From 8488f9297f90d3c3d3f27a56a52465aba9675774 Mon Sep 17 00:00:00 2001 From: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Date: Thu, 21 Aug 2025 04:25:40 +0000 Subject: [PATCH 2/7] test(middleware-endpoint-discovery): fix error reason --- .../src/updateDiscoveredEndpointInCache.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/middleware-endpoint-discovery/src/updateDiscoveredEndpointInCache.spec.ts b/packages/middleware-endpoint-discovery/src/updateDiscoveredEndpointInCache.spec.ts index f98fa6bfe4c34..897408db31eeb 100644 --- a/packages/middleware-endpoint-discovery/src/updateDiscoveredEndpointInCache.spec.ts +++ b/packages/middleware-endpoint-discovery/src/updateDiscoveredEndpointInCache.spec.ts @@ -117,7 +117,7 @@ describe(updateDiscoveredEndpointInCache.name, () => { `The operation to discover endpoint failed.` + ` Please retry, or provide a custom endpoint and disable endpoint discovery to proceed.` ), - { reason: error } + { reason: new Error("rejected") } ) ); } From 50a87fb63824f0f64b97ef367a654cb1f51fed76 Mon Sep 17 00:00:00 2001 From: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Date: Thu, 21 Aug 2025 04:27:39 +0000 Subject: [PATCH 3/7] test(middleware-sdk-s3): fix error name --- .../middleware-sdk-s3/src/region-redirect-middleware.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/middleware-sdk-s3/src/region-redirect-middleware.spec.ts b/packages/middleware-sdk-s3/src/region-redirect-middleware.spec.ts index b755f360397b4..6fd175e18c93e 100644 --- a/packages/middleware-sdk-s3/src/region-redirect-middleware.spec.ts +++ b/packages/middleware-sdk-s3/src/region-redirect-middleware.spec.ts @@ -60,7 +60,7 @@ describe(regionRedirectMiddleware.name, () => { await handler({ input: null }); }).rejects.toThrowError( Object.assign(new Error(), { - Code: "PermanentRedirect", + name: "PermanentRedirect", $metadata: { httpStatusCode: 301 }, $response: { headers: { "x-amz-bucket-region": redirectRegion } }, }) From bbda2202e154b470310b031424929ada792689c6 Mon Sep 17 00:00:00 2001 From: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Date: Thu, 21 Aug 2025 04:33:43 +0000 Subject: [PATCH 4/7] chore(credential-provider-ini): set tryNextLink=true in CredentialsProviderError --- .../src/resolveAssumeRoleCredentials.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/credential-provider-ini/src/resolveAssumeRoleCredentials.spec.ts b/packages/credential-provider-ini/src/resolveAssumeRoleCredentials.spec.ts index a6fcb82a6d107..6ed15c3c023f8 100644 --- a/packages/credential-provider-ini/src/resolveAssumeRoleCredentials.spec.ts +++ b/packages/credential-provider-ini/src/resolveAssumeRoleCredentials.spec.ts @@ -142,7 +142,7 @@ describe(resolveAssumeRoleCredentials.name, () => { `Detected a cycle attempting to resolve credentials for profile` + ` ${mockProfileName}. Profiles visited: ` + Object.keys({ mockProfileName: true }).join(", "), - false + { tryNextLink: true } ); try { From 4ae6dec69324fb3a193a47b62627f72be99f3f28 Mon Sep 17 00:00:00 2001 From: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Date: Thu, 21 Aug 2025 04:37:24 +0000 Subject: [PATCH 5/7] test(core): add type for bigDecimal --- .../submodules/protocols/json/JsonShapeSerializer.spec.ts | 2 +- .../core/src/submodules/protocols/json/jsonReplacer.spec.ts | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/core/src/submodules/protocols/json/JsonShapeSerializer.spec.ts b/packages/core/src/submodules/protocols/json/JsonShapeSerializer.spec.ts index aea832e7b7238..d1b818fc4e988 100644 --- a/packages/core/src/submodules/protocols/json/JsonShapeSerializer.spec.ts +++ b/packages/core/src/submodules/protocols/json/JsonShapeSerializer.spec.ts @@ -26,7 +26,7 @@ describe(JsonShapeSerializer.name, () => { serializer.write(widget, data); const serialization = serializer.flush(); expect(serialization).toEqual( - `{"blob":"AAAAAQ==","timestamp":0,"bigint":10000000000000000000000054321,"bigdecimal":0.10000000000000000000000054321}` + `{"blob":"AAAAAQ==","timestamp":0,"bigint":10000000000000000000000054321,"bigdecimal":{"string":"0.10000000000000000000000054321","type":"bigDecimal"}}` ); }); }); diff --git a/packages/core/src/submodules/protocols/json/jsonReplacer.spec.ts b/packages/core/src/submodules/protocols/json/jsonReplacer.spec.ts index 753f6f2ca611e..e140619f41cdc 100644 --- a/packages/core/src/submodules/protocols/json/jsonReplacer.spec.ts +++ b/packages/core/src/submodules/protocols/json/jsonReplacer.spec.ts @@ -24,7 +24,10 @@ describe(JsonReplacer.name, () => { const serialized = jsonReplacer.replaceInJson(JSON.stringify(data, jsonReplacer.createReplacer(), 2)); expect(serialized).toEqual(`{ - "numericValue": 0.1000000000000000000000000000054321 + "numericValue": { + "string": "0.1000000000000000000000000000054321", + "type": "bigDecimal" + } }`); }); From dbb9ab84f601a44288fddccc060c119d86abd2f2 Mon Sep 17 00:00:00 2001 From: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Date: Thu, 21 Aug 2025 04:59:21 +0000 Subject: [PATCH 6/7] test(s3-request-presigner): check for error name and message --- .../s3-request-presigner/src/getSignedUrl.spec.ts | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/packages/s3-request-presigner/src/getSignedUrl.spec.ts b/packages/s3-request-presigner/src/getSignedUrl.spec.ts index 8c78b8fa236e2..401c7c84b1bf2 100644 --- a/packages/s3-request-presigner/src/getSignedUrl.spec.ts +++ b/packages/s3-request-presigner/src/getSignedUrl.spec.ts @@ -196,9 +196,10 @@ describe("getSignedUrl", () => { }); }); - it("should throw if presign request with MRAP ARN and disableMultiregionAccessPoints option", () => { + it("should throw if presign request with MRAP ARN and disableMultiregionAccessPoints option", async () => { const mockPresigned = "a presigned url"; vi.mocked(mockS3RequestPresigner.presign).mockReturnValue(mockPresigned as any); + const client = new S3Client({ ...clientParams, disableMultiregionAccessPoints: true, @@ -207,13 +208,9 @@ describe("getSignedUrl", () => { Bucket: "arn:aws:s3::123456789012:accesspoint:mfzwi23gnjvgw.mrap", Key: "Key", }); - return expect(getSignedUrl(client, command)).rejects.toEqual( - new (class EndpointError extends Error { - constructor(...args: any[]) { - super(...args); - this.name = "EndpointError"; - } - })("Invalid configuration: Multi-Region Access Point ARNs are disabled.") - ); + + const error = await getSignedUrl(client, command).catch((e) => e); + expect(error.name).toEqual("EndpointError"); + expect(error.message).toEqual("Invalid configuration: Multi-Region Access Point ARNs are disabled."); }); }); From 8df66d6550dc1b7a0da15cfddad54711ef665e45 Mon Sep 17 00:00:00 2001 From: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Date: Thu, 21 Aug 2025 05:04:12 +0000 Subject: [PATCH 7/7] test(core): remove type for bigDecimal This reverts commit ab5c9cece6acee09bd6be37b68d2c3ed60947e59. --- .../submodules/protocols/json/JsonShapeSerializer.spec.ts | 2 +- .../core/src/submodules/protocols/json/jsonReplacer.spec.ts | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/core/src/submodules/protocols/json/JsonShapeSerializer.spec.ts b/packages/core/src/submodules/protocols/json/JsonShapeSerializer.spec.ts index d1b818fc4e988..aea832e7b7238 100644 --- a/packages/core/src/submodules/protocols/json/JsonShapeSerializer.spec.ts +++ b/packages/core/src/submodules/protocols/json/JsonShapeSerializer.spec.ts @@ -26,7 +26,7 @@ describe(JsonShapeSerializer.name, () => { serializer.write(widget, data); const serialization = serializer.flush(); expect(serialization).toEqual( - `{"blob":"AAAAAQ==","timestamp":0,"bigint":10000000000000000000000054321,"bigdecimal":{"string":"0.10000000000000000000000054321","type":"bigDecimal"}}` + `{"blob":"AAAAAQ==","timestamp":0,"bigint":10000000000000000000000054321,"bigdecimal":0.10000000000000000000000054321}` ); }); }); diff --git a/packages/core/src/submodules/protocols/json/jsonReplacer.spec.ts b/packages/core/src/submodules/protocols/json/jsonReplacer.spec.ts index e140619f41cdc..753f6f2ca611e 100644 --- a/packages/core/src/submodules/protocols/json/jsonReplacer.spec.ts +++ b/packages/core/src/submodules/protocols/json/jsonReplacer.spec.ts @@ -24,10 +24,7 @@ describe(JsonReplacer.name, () => { const serialized = jsonReplacer.replaceInJson(JSON.stringify(data, jsonReplacer.createReplacer(), 2)); expect(serialized).toEqual(`{ - "numericValue": { - "string": "0.1000000000000000000000000000054321", - "type": "bigDecimal" - } + "numericValue": 0.1000000000000000000000000000054321 }`); });