improve Steam logs on GetSteamProfile error (heroiclabs#1120)

Luke Gehorsam · web-flow · commit 8e8a0fe4f274 · 2023-10-30T13:40:58.000-04:00
diff --git a/server/core_authenticate.go b/server/core_authenticate.go
@@ -831,7 +831,7 @@ func importSteamFriends(ctx context.Context, logger *zap.Logger, db *sql.DB, mes
 
 	steamProfiles, err := client.GetSteamFriends(ctx, publisherKey, steamId)
 	if err != nil {
-		logger.Info("Could not import Steam friends.", zap.Error(err))
+		logger.Error("Could not import Steam friends.", zap.Error(err))
 		return status.Error(codes.Unauthenticated, "Could not authenticate Steam profile.")
 	}
 
diff --git a/social/social.go b/social/social.go
@@ -626,12 +626,15 @@ func (c *Client) GetSteamProfile(ctx context.Context, publisherKey string, appID
 	var profileWrapper SteamProfileWrapper
 	err := c.request(ctx, "steam profile", path, nil, &profileWrapper)
 	if err != nil {
+		c.logger.Debug("Error requesting Steam profile", zap.Error(err))
 		return nil, err
 	}
 	if profileWrapper.Response.Error != nil {
+		c.logger.Debug("Error returned from Steam after requesting Steam profile", zap.String("errorDescription", profileWrapper.Response.Error.ErrorDesc), zap.Int("errorCode", profileWrapper.Response.Error.ErrorCode))
 		return nil, fmt.Errorf("%v, %v", profileWrapper.Response.Error.ErrorDesc, profileWrapper.Response.Error.ErrorCode)
 	}
 	if profileWrapper.Response.Params == nil {
+		c.logger.Debug("No profile returned from Steam after requesting Steam profile")
 		return nil, errors.New("no steam profile")
 	}
 	return profileWrapper.Response.Params, nil

Original file line number	Diff line number	Diff line change
`@@ -831,7 +831,7 @@ func importSteamFriends(ctx context.Context, logger zap.Logger, db sql.DB, mes`
`831`	`831`
`832`	`832`	`steamProfiles, err := client.GetSteamFriends(ctx, publisherKey, steamId)`
`833`	`833`	`if err != nil {`
`834`		`- logger.Info("Could not import Steam friends.", zap.Error(err))`
	`834`	`+ logger.Error("Could not import Steam friends.", zap.Error(err))`
`835`	`835`	`return status.Error(codes.Unauthenticated, "Could not authenticate Steam profile.")`
`836`	`836`	`}`
`837`	`837`
Original file line number	Diff line number	Diff line change
`@@ -626,12 +626,15 @@ func (c *Client) GetSteamProfile(ctx context.Context, publisherKey string, appID`
`626`	`626`	`var profileWrapper SteamProfileWrapper`
`627`	`627`	`err := c.request(ctx, "steam profile", path, nil, &profileWrapper)`
`628`	`628`	`if err != nil {`
	`629`	`+ c.logger.Debug("Error requesting Steam profile", zap.Error(err))`
`629`	`630`	`return nil, err`
`630`	`631`	`}`
`631`	`632`	`if profileWrapper.Response.Error != nil {`
	`633`	`+ c.logger.Debug("Error returned from Steam after requesting Steam profile", zap.String("errorDescription", profileWrapper.Response.Error.ErrorDesc), zap.Int("errorCode", profileWrapper.Response.Error.ErrorCode))`
`632`	`634`	`return nil, fmt.Errorf("%v, %v", profileWrapper.Response.Error.ErrorDesc, profileWrapper.Response.Error.ErrorCode)`
`633`	`635`	`}`
`634`	`636`	`if profileWrapper.Response.Params == nil {`
	`637`	`+ c.logger.Debug("No profile returned from Steam after requesting Steam profile")`
`635`	`638`	`return nil, errors.New("no steam profile")`
`636`	`639`	`}`
`637`	`640`	`return profileWrapper.Response.Params, nil`