cargo clippy project

Author: bestgopher

README.md

@@ -9,7 +9,7 @@ use crate::http::Resp;
 pub fn all() {
     let files = file::get_all_bin_file();
 
-    let mut v = Vec::<Resp>::with_capacity(files.len());
+    let v = Vec::<Resp>::with_capacity(files.len());
 
     let x = Arc::new(Mutex::new(v));
     let mut handlers = vec![];
@@ -26,14 +26,15 @@ pub fn all() {
 
         handlers.push(thread::spawn(move || {
             for i in files {
+                println!("{} downloading", i);
                 let resp = crate::http::get_question_info(&i);
                 x.lock().unwrap().push(resp);
             }
         }))
     }
 
     for i in handlers {
-        i.join();
+        i.join().unwrap();
     }
 
     crate::file::write_readme(&mut *x.lock().unwrap());

src/all.rs

@@ -44,7 +44,7 @@ impl Solution {
         count
     }
 
-    pub fn num_rescue_boats(mut people: Vec<i32>, limit: i32) -> i32 {
+    pub fn num_rescue_boats(people: Vec<i32>, limit: i32) -> i32 {
         let mut v = vec![0; (limit + 1) as usize];
 
         for i in people {

src/bin/boats-to-save-people.rs

@@ -1,4 +1,4 @@
-use std::ptr::hash;
+
 
 fn main() {}
 
@@ -12,7 +12,7 @@ impl Solution {
 
         let (mut a, mut b) = (1, 2);
 
-        for i in 3..=n {
+        for _i in 3..=n {
             let a1 = a;
             a = b;
             b = a1 + b;

src/bin/climbing-stairs.rs

@@ -22,7 +22,7 @@ impl Solution {
                 v.push(i);
                 r.push(v);
             } else if i < target {
-                let mut x = Self::calc(&candidates, target - i);
+                let x = Self::calc(&candidates, target - i);
                 for mut m in x {
                     if !m.is_empty() {
                         if i >= *m.last().unwrap() {

src/bin/combination-sum.rs

@@ -23,7 +23,7 @@ impl TreeNode {
 }
 
 use std::cell::RefCell;
-use std::ops::Deref;
+
 use std::rc::Rc;
 
 struct Solution;

src/bin/construct-binary-search-tree-from-preorder-traversal.rs

@@ -21,9 +21,9 @@ impl TreeNode {
     }
 }
 
-use std::arch::x86_64::_mm_xor_pd;
+
 use std::cell::RefCell;
-use std::cmp::{max, min};
+
 use std::rc::Rc;
 
 impl Solution {
@@ -70,7 +70,7 @@ impl Solution {
         }
 
         while max_count - min_count > 1 {
-            let mut middle = (min_count + max_count) / 2;
+            let middle = (min_count + max_count) / 2;
 
             let e = exists(root.as_ref(), middle, level);
             if e {

src/bin/count-complete-tree-nodes.rs

@@ -8,7 +8,7 @@ impl Solution {
             return n;
         }
         let (mut last, mut result) = (1, 1);
-        for i in 2..n {
+        for _i in 2..n {
             let result1 = result + last;
             last = result;
             result = result1 % 1000000007;

src/bin/fei-bo-na-qi-shu-lie-lcof.rs

@@ -27,7 +27,7 @@ impl Solution {
         }
 
         let index = Self::split(&arr, x);
-        let (mut start, mut end, mut k) = (index, index, k as usize);
+        let (mut start, mut end, k) = (index, index, k as usize);
         while end - start < k - 1 {
             if start == 0 {
                 end += 1;

src/bin/find-k-closest-elements.rs

@@ -16,7 +16,7 @@ impl Solution {
                 .or_insert(vec![i]);
         }
 
-        hash.into_iter().map(|(x, y)| y).collect()
+        hash.into_iter().map(|(_x, y)| y).collect()
     }
 
     // 计算字母出现的个数
@@ -37,6 +37,6 @@ impl Solution {
             }
         }
 
-        hash.into_iter().map(|(x, y)| y).collect()
+        hash.into_iter().map(|(_x, y)| y).collect()
     }
 }

src/bin/group-anagrams.rs

@@ -17,7 +17,7 @@ impl Solution {
     }
 
     fn heapify(nums: &mut [i32]) {
-        let mut index = (nums.len() - 1) / 2;
+        let index = (nums.len() - 1) / 2;
 
         for i in (0..=index).rev() {
             Self::down_heap(nums, i);

src/bin/kth-largest-element-in-an-array.rs

@@ -10,7 +10,7 @@ impl Solution {
             h.entry(i).and_modify(|x| *x += 1).or_insert(1);
         }
 
-        let mut s = h.iter().map(|(x, y)| *y).collect::<Vec<i32>>();
+        let mut s = h.iter().map(|(_x, y)| *y).collect::<Vec<i32>>();
         s.sort();
 
         let (mut l, mut k) = (h.len(), k);

src/bin/least-number-of-unique-integers-after-k-removals.rs

@@ -11,7 +11,7 @@ impl Solution {
 
     fn func(s: String, v: &mut Vec<String>, index: usize) {
         let mut new_s = s.clone();
-        let mut new_s = unsafe { new_s.as_bytes_mut() };
+        let new_s = unsafe { new_s.as_bytes_mut() };
         v.push(s);
         if index == new_s.len() {
             return;

src/bin/letter-case-permutation.rs

@@ -1,4 +1,4 @@
-use std::collections::HashMap;
+
 
 fn main() {
     assert_eq!(2, Solution::length_of_longest_substring("aab".to_string()));

src/bin/longest-substring-without-repeating-characters.rs

@@ -3,7 +3,7 @@ fn main() {}
 struct Solution;
 
 impl Solution {
-    pub fn magical_string(mut n: i32) -> i32 {
+    pub fn magical_string(n: i32) -> i32 {
         if n == 0 {
             return 0;
         }

src/bin/magical-string.rs

@@ -22,8 +22,8 @@ impl Solution {
         }
 
         m.iter()
-            .filter(|(&x, &y)| y > length)
-            .map(|(&x, &y)| x)
+            .filter(|(&_x, &y)| y > length)
+            .map(|(&x, &_y)| x)
             .collect()
     }
 
@@ -106,7 +106,7 @@ impl Solution {
                 None
             })
             .filter(|x| x.is_some())
-            .map(|mut x| x.unwrap())
+            .map(|x| x.unwrap())
             .collect()
     }
 }

src/bin/majority-element-ii.rs

@@ -8,7 +8,7 @@ impl Solution {
 
         for i in 0..words.len() {
             for &j in words[i].as_bytes() {
-                v[i] |= (1 << (j - b'a'));
+                v[i] |= 1 << (j - b'a');
             }
         }
 

src/bin/maximum-product-of-word-lengths.rs

@@ -8,7 +8,7 @@ fn main() {
 struct Solution;
 
 impl Solution {
-    pub fn find_complement(mut num: i32) -> i32 {
+    pub fn find_complement(num: i32) -> i32 {
         let lz = num.leading_zeros();
         !num << lz >> lz
     }

src/bin/number-complement.rs

@@ -6,7 +6,10 @@ impl Solution {
     pub fn sum_nums(n: i32) -> i32 {
         let mut n = n;
         // 利用布尔短路的思想，n == 0 时，不会允许&&后面的表达式
-        n > 0 && (n += Self::sum_nums(n - 1)) == ();
+        if n > 0 {
+            n += Self::sum_nums(n - 1);
+        }
+
         n
     }
 }

src/bin/qiu-12n-lcof.rs

@@ -34,7 +34,7 @@ impl Solution {
         let mut root = v.pop().unwrap();
         let mut s = &mut root;
         while !v.is_empty() {
-            let mut node = v.pop().unwrap();
+            let node = v.pop().unwrap();
             s.as_mut().unwrap().next = node;
             s = &mut s.as_mut().unwrap().next;
         }

src/bin/reverse-linked-list.rs

@@ -7,7 +7,7 @@ impl Solution {
         if s.is_empty() {
             return s;
         }
-        let mut s = s.as_bytes();
+        let s = s.as_bytes();
         let (mut start, mut end) = (0, s.len() - 1);
 
         for i in 0..s.len() {

src/bin/reverse-words-in-a-string.rs

@@ -6,7 +6,7 @@ struct Solution;
 
 impl Solution {
     /// 只有(x,y)不是原点，并且方向和原来的方向一致，最后才回不去
-    pub fn is_robot_bounded(mut instructions: String) -> bool {
+    pub fn is_robot_bounded(instructions: String) -> bool {
         let mut start = (0, 0);
         let mut direction = 0u8; // 当前的方向，0为向前，1为向左，2为向后，3为向右
 

src/bin/robot-bounded-in-circle.rs

@@ -1,4 +1,4 @@
-use std::os::macos::raw::stat;
+
 
 fn main() {
     assert_eq!(4, Solution::search(vec![4, 5, 6, 7, 8, 1, 2, 3], 8));

src/bin/search-in-rotated-sorted-array.rs

@@ -4,7 +4,7 @@ struct Solution;
 
 impl Solution {
     pub fn my_sqrt(x: i32) -> i32 {
-        let mut s = x as f64;
+        let s = x as f64;
         let mut x1 = x as f64;
 
         while (s - x1 * x1).abs() > 0.1 {

src/bin/sqrtx.rs

@@ -1,4 +1,4 @@
-use serde_json::ser::CharEscape::Solidus;
+
 
 fn main() {
     println!("{:?}", Solution::summary_ranges(vec![0, 1, 2, 4, 5, 7]));

src/bin/summary-ranges.rs

@@ -58,8 +58,8 @@ impl Solution {
             index += 1;
         }
 
-        let f = k_node.unwrap().val;
-        let s = slow.unwrap().val;
+        let _f = k_node.unwrap().val;
+        let _s = slow.unwrap().val;
 
         head
     }

src/bin/swapping-nodes-in-a-linked-list.rs

@@ -52,7 +52,7 @@ pub fn write_question(resp: Resp) {
     for i in resp.data.question.code_snippets {
         if i.lang == "Rust" {
             s.push_str(i.code.replace("↵", "\n").as_str());
-            s.push_str("\n");
+            s.push('\n');
             break;
         }
     }

src/file.rs

@@ -8,7 +8,7 @@ lazy_static! {
     static ref RE: Regex = Regex::new(r".*?/problems/(.*?)/").unwrap();
 }
 
-const URL: &'static str = "https://leetcode-cn.com/graphql/";
+const URL: &str = "https://leetcode-cn.com/graphql/";
 
 #[derive(Deserialize, Serialize, Debug)]
 pub struct Ques {

src/http.rs

@@ -26,7 +26,7 @@ pub fn run() {
             Ok(x) => new::new(x),
             Err(_) => println!("please input the name of question")
         }
-    } else if let Some(_) = matches.subcommand_matches("all") {
+    } else if matches.subcommand_matches("all").is_some() {
         all::all();
     } else {
         git::push();

src/lib.rs

@@ -1,5 +1,3 @@
-use leetcode;
-
 fn main() {
     leetcode::run()
 }

src/main.rs

@@ -1,8 +1,8 @@
 use lazy_static::lazy_static;
-use tera::{Tera, Context, Error as TeraError, ErrorKind, Result as TeraResult};
+use tera::{Tera, Context, Result as TeraResult};
 
 /// 模板内容
-const TEMPLATE_STR: &'static str = r"# leetcode
+const TEMPLATE_STR: &str = r"# leetcode
 
 当前已刷：{{ datas | length }}
 
@@ -13,10 +13,8 @@ const TEMPLATE_STR: &'static str = r"# leetcode
 {% for t in datas %}|{{ t.data.question.questionId }}    | {{ t.data.question.translatedTitle }} | [src](https://github.com/rustors/leetcode/blob/main/src/bin/{{ t.data.question.titleSlug }}.rs) | [leetcode](https://leetcode-cn.com/problems/{{ t.data.question.titleSlug }}) |
 {% endfor %}";
 
-static A: &str = "";
-
 /// 模板名字
-const TEMPLATE_NAME: &'static str = "leetcode";
+const TEMPLATE_NAME: &str = "leetcode";
 
 lazy_static!(
     /// 用于渲染的模板
@@ -29,7 +27,7 @@ lazy_static!(
 
 
 /// 把传入的内容渲染为模板内容
-pub fn render(data: &Vec<crate::http::Resp>) -> TeraResult<String> {
+pub fn render(data: &[crate::http::Resp]) -> TeraResult<String> {
     let mut ctx = Context::new();
     ctx.insert("datas", data);
 
@@ -51,7 +49,7 @@ mod tests {
                         title_slug: "aaa".to_string(),
                         translated_title: "中国".to_string(),
                         code_snippets: vec![],
-                        difficulty: String::new();
+                        difficulty: String::new(),
                     }
                 },
             },