Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google guidance on code review #1759

Closed
bernhold opened this issue Aug 4, 2023 · 3 comments
Closed

Google guidance on code review #1759

bernhold opened this issue Aug 4, 2023 · 3 comments
Labels
content: curated For curated content

Comments

@bernhold
Copy link
Member

bernhold commented Aug 4, 2023

This resource (which is short, but references deeper resources) was recommended by Randy Pierce at the NOAA BSSw tutorial. It seems like it might be useful to add as a curated content article. Maybe the article would include a number of similar resources.

https://google.github.io/eng-practices/review/
@bernhold bernhold added the content: curated For curated content label Aug 4, 2023
@bartlettroscoe
Copy link
Member

@betterscientificsoftware/bssw-editorial-board, I am supposed to write a CC article for August and I have been looking there a bunch of Issues and this seems like one I could produce pretty fast and it could be useful.

So without objection, I will write a CC article for this for August.

bartlettroscoe added a commit to bartlettroscoe/bssw.io that referenced this issue Aug 16, 2023
@bartlettroscoe
WIP: Create skeleton for CC article (betterscientificsoftware#1759)
5f9ed50
bartlettroscoe added a commit to bartlettroscoe/bssw.io that referenced this issue Aug 21, 2023
@bartlettroscoe
CC: First draft of Google Guidance on Code Review (betterscientificso…
922e557 
…ftware#1759)
@bartlettroscoe bartlettroscoe mentioned this issue Aug 21, 2023
Merged
19 tasks
@bartlettroscoe
Copy link
Member

FYI: I just posted PR:

Does someone have time to do a quick review of this? If not, I will look at this again in a few days to try to catch any defects.

bartlettroscoe added a commit to bartlettroscoe/bssw.io that referenced this issue Aug 24, 2023
@bartlettroscoe
Try to improve text about CL and commits (betterscientificsoftware#1759)
06ce8b2 
Tried to make the text more clear based on review feedback from @rinkug.
rinkug added a commit that referenced this issue Aug 25, 2023
@rinkug
Merge pull request #1781 from bartlettroscoe/1759-google-code-review
81aadb5 
CC: First draft of Google Guidance on Code Review (#1759)
@bartlettroscoe
Copy link
Member

With the merge of PR:

this is complete.

bartlettroscoe added a commit to bartlettroscoe/bssw.io that referenced this issue Aug 31, 2023
@bartlettroscoe
Fix a few typos I noticed after publication (betterscientificsoftware…
e413622 
…#1759)
bartlettroscoe added a commit that referenced this issue Aug 31, 2023
@bartlettroscoe
Merge pull request #1799 from bartlettroscoe/1759-code-review-fixups
9ee1261 
Fix a few typos I noticed after publication (#1759)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content: curated For curated content
Projects
Content Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bernhold @bartlettroscoe