Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async support #130

Open
Niccolum opened this issue Mar 29, 2022 · 3 comments
Open

Async support #130

Niccolum opened this issue Mar 29, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Niccolum
Copy link

Before submitting a new issue, please check if a similar issue has already been filed.

Issue subject

Can you create async classes, based on httpx or aiohttp client.

Expected behaviour

Async support for api

Actual behaviour

Only sync connector supported

@2pd 2pd added the enhancement New feature or request label Apr 4, 2022
@2pd
Copy link
Contributor

2pd commented Apr 4, 2022

It's in our list, but unfortunately, it's not in high priority.

@d3thomas
Copy link

What is the status of async support? This would be a good addition.

@Ephraim-Akolo
Copy link

Ephraim-Akolo commented Jul 19, 2023

I have added support for async API, and I wish to create a pull request.
The async support is based on httpx.
Replicated all tests from the sync to the async and all passed 100%.
Async requests work fine and are identical to the sync version in code
example import: from binance.async_spot import AsyncSpot
Feature branch link:here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants