Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial test program hangs #132

Open
chill1n opened this issue Apr 8, 2022 · 1 comment
Open

Trivial test program hangs #132

chill1n opened this issue Apr 8, 2022 · 1 comment
Labels
reviewing reviewing the issue

Comments

@chill1n
Copy link

chill1n commented Apr 8, 2022

Before submitting a new issue, please check if a similar issue has already been filed.

Trivial websocket program hangs

If only a websocket instance is created and start()ed, it will hang if stop() is called without executing a subscription (for instance).

Expected behaviour

A websocket program should terminate gracefully and immediately after calling stop()

Actual behaviour

Program does not terminate.

Steps to reproduce

from binance.websocket.spot.websocket_client import SpotWebsocketClient as WebsocketClient

ws_client = WebsocketClient()
ws_client.start()
ws_client.stop()

Environment

Default system and setup

@2pd 2pd added the reviewing reviewing the issue label Apr 8, 2022
@2pd
Copy link
Contributor

2pd commented Feb 16, 2023

Please have a try on the latest v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewing reviewing the issue
Projects
None yet
Development

No branches or pull requests

2 participants