Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configurable "rank types" #283

Open
6 tasks
fedarko opened this issue Mar 3, 2020 · 0 comments
Open
6 tasks

Support configurable "rank types" #283

fedarko opened this issue Mar 3, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request external issues/bugs with other libraries, frameworks, etc.; might include reproducing an issue minimally interoperability Making Qurro work well with other bioinformatics tools

Comments

@fedarko
Copy link
Collaborator

fedarko commented Mar 3, 2020

progress

  • rename ranking selector label
  • rename rank plot y-axis label
  • remove python code that sends a "rank type" to the JS code in one of the JSONs
  • remove JS code that makes these changes based on the rank type
  • un-break JS unit tests checking that these changes are applied
  • Adjust standalone Qurro CLI accordingly

problem explanation

So here's the problem: if you perform Aitchison PCA yourself (for example, in the soon-to-be-merged-in color composition tutorial -- thanks @cameronmartino!!!), you already have the sample and feature loadings conveniently in a DataFrame. It's totally possible to just output the feature loadings to a TSV file, and then use that in standalone Qurro as the --ranks. (This is easier than building up a skbio OrdinationResults object yourself.) edit: the tutorial currently does that to avoid this problem.

However, a problem with that is that Qurro's code sees that you passed in a TSV file and assumes that it was a file of differentials -- so the Qurro interface will be all like "yeah check out all of these differentials that just happen to be named PC1, PC2, PC3, ..." for the ranking selector and for the rank plot y-axis, which is obviously misleading since these aren't differentials.

Screen Shot 2020-03-03 at 1 56 36 PM

One solution to this problem is adding a --rank-type command-line parameter for standalone Qurro that'd let you adjust the text shown in the interface, but I feel like no one will use that. An easier solution (and one that would also knock out a lot of the problems associated with #281) would just be renaming the ranking selector back from Differential/Feature Loading to just Ranking, and renaming the y-axis prefix from Differential/Feature Loading to Magnitude or Value or something.

@fedarko fedarko added enhancement New feature or request external issues/bugs with other libraries, frameworks, etc.; might include reproducing an issue minimally labels Mar 3, 2020
@fedarko fedarko self-assigned this Mar 3, 2020
@fedarko fedarko added the interoperability Making Qurro work well with other bioinformatics tools label May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external issues/bugs with other libraries, frameworks, etc.; might include reproducing an issue minimally interoperability Making Qurro work well with other bioinformatics tools
Projects
None yet
Development

No branches or pull requests

1 participant