Improper handling of translation token "viewItemHeader"

[poschi3]

Steps To Reproduce

1. Set language to German
2. Go to vault item (e.g. credentials)
3. Look to heading

Expected Result

"Zugangsdaten ansehen"

Actual Result

"zugangsdaten ansehen"

Screenshots or Videos

Additional Context

Problem is that translation string in englisch is View $TYPE$ and so code does a toLowerCaseon $TYPE$. But in German grammar it must be the other way around: $TYPE$ ansehen and the the toLowerCase leads to a grammar error.

clients/apps/browser/src/vault/popup/components/vault-v2/view-v2/view-v2.component.ts

Lines 146 to 162 in 395258d

	setHeader(type: CipherType) {
	switch (type) {
	case CipherType.Login:
	return this.i18nService.t("viewItemHeader", this.i18nService.t("typeLogin").toLowerCase());
	case CipherType.Card:
	return this.i18nService.t("viewItemHeader", this.i18nService.t("typeCard").toLowerCase());
	case CipherType.Identity:
	return this.i18nService.t(
	"viewItemHeader",
	this.i18nService.t("typeIdentity").toLowerCase(),
	);
	case CipherType.SecureNote:
	return this.i18nService.t("viewItemHeader", this.i18nService.t("note").toLowerCase());
	case CipherType.SshKey:
	return this.i18nService.t("viewItemHeader", this.i18nService.t("typeSshkey").toLowerCase());
	}
	}

There is already a discussion on Crowdin but it can't be fixed in translation strings only

Problem also exits for Cards and all other item types

Operating System

Linux

Operating System Version

Ubuntu 22.04

Web Browser

Firefox

Browser Version

133.0.3

Build Version

2024.12.3

Issue Tracking Info

• I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.

[bitwarden-bot]

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-16452

[djsmith85]

Thanks for the report @poschi3

I was also following the forum thread and opened a PR to address this.

This will likely be included and fixed in the next release.

Greetings from Germany!