Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with bioavalibility parameter in dose_absorb macro #17

Closed
blakeaw opened this issue Jul 18, 2024 · 1 comment
Closed

Problem with bioavalibility parameter in dose_absorb macro #17

blakeaw opened this issue Jul 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@blakeaw
Copy link
Owner

blakeaw commented Jul 18, 2024

I get an error when the input bioavailability (f=) to the dose_absorb macro is already a Parameter.

Offending code:

    if not isinstance(f, Parameter):
        F = Parameter("F_{0}_{1}".format(monomer_name, comp_name), f)
        params_created.add(F)
    pre_0_expr = Expression('precursor_0', (dose_expr * F))

When the argument f is a Parameter, the variable F is not created and the pre_0_expr expression errors out.

@blakeaw blakeaw added the bug Something isn't working label Jul 18, 2024
@blakeaw blakeaw mentioned this issue Jul 18, 2024
@blakeaw
Copy link
Owner Author

blakeaw commented Jul 18, 2024

Fixed with PR #19

@blakeaw blakeaw closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant