Skip to content

Commit

Permalink
Fix Warning on PHP8
Browse files Browse the repository at this point in the history
PHP8 emits a warning when `final` and `private` are used on the same method.

```
Warning: Private methods cannot be final as they are never overridden by other classes in {file} on line {line}
```

Example: https://3v4l.org/p2Ccp
  • Loading branch information
mgrinspan authored Mar 18, 2021
1 parent 325384e commit a539ebf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Application/Application.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ protected function __construct()
// singleton construct required this method to be protected/private
}

final private function __clone()
final protected function __clone()
{
// singleton construct required this method to be protected/private
}
Expand Down

0 comments on commit a539ebf

Please sign in to comment.