Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens if you stop supporting this project? #42

Closed
lfaoro opened this issue Jan 13, 2020 · 6 comments
Closed

What happens if you stop supporting this project? #42

lfaoro opened this issue Jan 13, 2020 · 6 comments

Comments

@lfaoro
Copy link

lfaoro commented Jan 13, 2020

I'd like to switch to this keyset although I'm worried if supports ceases we'll end up having to switch back and rewiring our brain to the standard hotkeys

@bobo38
Copy link
Owner

bobo38 commented Jan 13, 2020

This repository will still be online

Orphan or no longer supported custom hotkey setups require minor adjust patch after patch: this was the status as I started the work on TheCore Lite (no update since JaKaTaK's release on TeamLiquid). Many players still use unsupported version of TheCore and keep making them work. There is not as many changes in SC2 those days, as it have been with LoTV release, Nova mission pack, Coop commander releases. Foundations should be solid enough to go this way with limited effort

If I disappear from the web, some volunteer might fork this repository and maintain on the long run (or a group of persons, but I don't think this big of a community would be needed)

@lfaoro
Copy link
Author

lfaoro commented Jan 22, 2020

thank you @bobo38 I appreciate your effort, I will start the switch. Meanwhile if you need any help with the project, let me know -- I'm a developer.

@lfaoro lfaoro closed this as completed Jan 22, 2020
@bobo38
Copy link
Owner

bobo38 commented Jan 22, 2020

The python code to check the Seed is ugly dirty but just works. I'm waiting for significant progress on ConflictChecks.py and Defaults.ini extraction from data game harvesting automation to start making it better

Any issue with the hotkey setup can be pointed at as a bug on this bug tracker or on Discord channel (then I can file it a bug here). As well any enhancement in user's local copy could be communicated and arbitrated for modification to be used upstream. Such example #24 (Queen and Overlord on E)

At patch update, some users helped submitting pull request to bind new commanders. I appreciate a lot, as I'm not myself a Coop player. That's quite helpful. If I do myself, my goal is fix unbounds with something that seems to make sense but I cannot test, lack of time and interest to run commander up to level 15 for last detail optimization

Examples:
#40 (Stettman)
#41 (Mengsk)
=> best pull-request would be done on US QWERTY or in TheCore Lite.SC2Hotkeys seed at root of the repository to avoid the pain of keyboard layout translation (last time it was not too painful to convert from French AZERTY to US QWERTY manually, so that there is no real need for automation there)

@lfaoro
Copy link
Author

lfaoro commented Jan 23, 2020

Maybe we can drop support for other layouts? It's just easier to switch your system keyboard layout to US when you play starcraft rather than us supporting a dozen layouts which are already system supported anyway.

@lfaoro
Copy link
Author

lfaoro commented Jan 23, 2020

What is exactly the Seed check? I can reimplement the tools you need, although I need a full description of what these tools have to do and which data they need to manipulate.

We can have a chat where I take notes.

@bobo38
Copy link
Owner

bobo38 commented Jan 26, 2020

Converting to other keyboard layouts is the easy part ;-) The one which works and was primary purpose in original repository

All the logs .log at root of project are checks' logs, some are from beginning of TheCore: output and code are dirty but just works. I can support new SC2 content in 1-2 hours and spot regression that cannot be found easily within GUI.

If you're interested in supporting SC2 community with your coding skills you can join here and see discussions
https://discord.gg/qseNPub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants