Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithms do not heed the maximum work-group size of the device #740

Open
doe300 opened this issue Sep 1, 2017 · 0 comments
Open

Algorithms do not heed the maximum work-group size of the device #740

doe300 opened this issue Sep 1, 2017 · 0 comments

Comments

@doe300
Copy link

doe300 commented Sep 1, 2017

Almost all algorithms in boost compute, which set an explicit local work-group size do not check if this size exceeds the device maximum work-group size. Instead they all set it to a default value of 128 (e.g. algorithm/detail/binary_find.hpp in line 82).

Thus, most of the algorithms and therefore the Boost.Compute test-cases fail for OpenCL devices with a maximum work-group size of less then 128.

So, the default value should be checked against the device's maximum work-group size, which already can be retrieved via boost::compute::device::max_work_group_size().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants