Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only inherit when the class is empty #149

Open
pfultz2 opened this issue Mar 15, 2016 · 1 comment
Open

Only inherit when the class is empty #149

pfultz2 opened this issue Mar 15, 2016 · 1 comment
Labels
bug design

Comments

@pfultz2
Copy link
Collaborator

pfultz2 commented Mar 15, 2016

The main reason for inheritance is to take advantage of EBO. So it might be best to only inherit when classes are empty. This is related to issue #129, and may supersede it.
@pfultz2
Copy link
Collaborator Author

pfultz2 commented Mar 21, 2016

The nice thing about inheritance is easy access to the base class. I think it would be better to keep inheritance and the user can use final or fit::protect to avoid possible problems that come from inheritance, but I am not sure which would be the better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viboes @pfultz2