Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue view doesn't handle GitHub Markdown checkboxes properly [reopened] #80

Open
rappo opened this issue Jul 18, 2013 · 9 comments · Fixed by #253
Open

Issue view doesn't handle GitHub Markdown checkboxes properly [reopened] #80

rappo opened this issue Jul 18, 2013 · 9 comments · Fixed by #253

Comments

@rappo
Copy link

rappo commented Jul 18, 2013

Checkboxes on Bountysource currently look like:
image

and they should look like:
image

URL to example above:
https://www.bountysource.com/issues/538209

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@MaksJS
Copy link

MaksJS commented Aug 20, 2013

Github checkboxes are not part of Markdown, they've got their own logic
(it sends a request when you check it) so you can't have them, but
here's the workaround

MaksJS@46d1f59

@CruzBishop
Copy link

I'm going to have a go at this, see what I can do :)

CruzBishop added a commit to CruzBishop/frontend that referenced this issue Oct 7, 2013
This is the start of the process of fixing bountysource#80

Signed-off-by: Cruz Julian Bishop <[email protected]>
CruzBishop added a commit to CruzBishop/frontend that referenced this issue Oct 7, 2013
Some more work is needed to render completed items.

References bountysource#80

Signed-off-by: Cruz Julian Bishop <[email protected]>
CruzBishop added a commit to CruzBishop/frontend that referenced this issue Oct 7, 2013
This is the last image-related change.

Ref: bountysource#80

Signed-off-by: Cruz Julian Bishop <[email protected]>
@CruzBishop
Copy link

I've submitted a pull request for the front end work, and added a new issue for the back end work. If the back end work is done according to the proposal, no more front end work will need to be done - Otherwise, I'd be happy to modify the front end again.

@rappo
Copy link
Author

rappo commented Jun 9, 2014

This issue is back, they're now displayed as plain text. See example url in the top post
image

@rappo rappo reopened this Jun 9, 2014
@CruzBishop
Copy link

Damn it

I'll reformat back to Arch tonight and have a look over the next few days, see what's going on. Here I was thinking I was safe :P

Any estimates on how long ago it stopped working? A few days? Today?

@rappo
Copy link
Author

rappo commented Jun 10, 2014

I'm sure it's something we did and didn't notice until recently. At some point we changed how issue bodies were rendering. Possibly 2-3 months ago? @corytheboyd any idea?

@corytheboyd
Copy link

I believe we started storing markdown source instead of the rendered HTML.

@wkonkel wkonkel changed the title Issue view doesn't handle GitHub Markdown checkboxes properly Issue view doesn't handle GitHub Markdown checkboxes properly [$50 awarded] Feb 18, 2015
@wkonkel wkonkel changed the title Issue view doesn't handle GitHub Markdown checkboxes properly [$50 awarded] Issue view doesn't handle GitHub Markdown checkboxes properly Feb 18, 2015
@wkonkel wkonkel changed the title Issue view doesn't handle GitHub Markdown checkboxes properly Issue view doesn't handle GitHub Markdown checkboxes properly [$50 awarded] Feb 18, 2015
@wkonkel wkonkel added bounty and removed bounty labels Feb 18, 2015
@wkonkel wkonkel changed the title Issue view doesn't handle GitHub Markdown checkboxes properly [$50 awarded] Issue view doesn't handle GitHub Markdown checkboxes properly Feb 20, 2015
@wkonkel wkonkel changed the title Issue view doesn't handle GitHub Markdown checkboxes properly Issue view doesn't handle GitHub Markdown checkboxes properly [$50 awarded] Feb 20, 2015
@rappo rappo changed the title Issue view doesn't handle GitHub Markdown checkboxes properly [$50 awarded] Issue view doesn't handle GitHub Markdown checkboxes properly [reopened] May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@wkonkel @CruzBishop @corytheboyd @MaksJS @rappo @seanders and others