Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional parameters to cellfinder napari UI #330

Open
alessandrofelder opened this issue Feb 11, 2022 · 2 comments
Open

Add additional parameters to cellfinder napari UI #330

alessandrofelder opened this issue Feb 11, 2022 · 2 comments
Labels
cellfinder-napari Issue concerns the napari plugin

Comments

@alessandrofelder
Copy link
Member

alessandrofelder commented Feb 11, 2022

# TODO: params to add
NETWORK_VOXEL_SIZES = [5, 1, 1]
CUBE_WIDTH = 50
CUBE_HEIGHT = 20
CUBE_DEPTH = 20

Created based on TODO in code.

alessandrofelder referenced this issue in brainglobe/cellfinder-napari Feb 11, 2022
move TODOs to issues #52, #53
alessandrofelder referenced this issue in brainglobe/cellfinder-napari Feb 15, 2022
move TODOs to issues #52, #53
paddyroddy referenced this issue in brainglobe/cellfinder-napari Feb 22, 2022
move TODOs to issues #52, #53
@alessandrofelder
Copy link
Member Author

@adamltyson are the above the only parameters that need adding to detect?
Are there parameters that need adding in train and curate?
And where in the GUI should they go?

@adamltyson
Copy link
Member

adamltyson commented Mar 13, 2022

Both detect and train should (as far as possible, practicable) have the same parameters as the functions they call in cellfinder-core. Descriptions for docstrings can be found in the existing CLI tools (detect, train).

The extra parameters could probably just be added to the bottom of the corresponding widgets. Maybe an "advanced" section could useful.

curate is a GUI-only tool, so nothing to add.

@willGraham01 willGraham01 added the cellfinder-napari Issue concerns the napari plugin label Jan 3, 2024
@willGraham01 willGraham01 transferred this issue from brainglobe/cellfinder-napari Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cellfinder-napari Issue concerns the napari plugin
Projects
No open projects
Development

No branches or pull requests

3 participants