Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inappropriate handling of unsigned integer data types #383

Closed
alessandrofelder opened this issue Feb 13, 2024 · 1 comment · Fixed by #388
Closed

[BUG] Inappropriate handling of unsigned integer data types #383

alessandrofelder opened this issue Feb 13, 2024 · 1 comment · Fixed by #388
Assignees
Labels
bug Something isn't working

Comments

@alessandrofelder
Copy link
Member

alessandrofelder commented Feb 13, 2024

Describe the bug

The connect_four function in structure_detection.py is called by structure_splitting.py:ball_filter_imgs with planes of type uint16
. Inside the connect_four function, we assign plane[x,y] to struct_id, a uint64. If there are more than 2**16-1 (temporary struct id) this will lead to confusion between structure with id 1 and structure 2**16!

To Reproduce
Pass cellfinder.detect a dataset that contains more than 2**16 individual structures.

Expected behaviour
Cell detection should be able to deal with >65000 structures.

Computer used (please complete the following information):

22.04.1-Ubuntu on a Dell Desktop

@alessandrofelder
Copy link
Member Author

alessandrofelder commented Feb 20, 2024

For completeness sake (so we know what happened), this used to work in Cython, because plane (then layer) used to consist of uint64 s... so this was introduced as part of the numba refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant