Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Path to trained model from brainmapper is a str, and doesn't have .suffix attribute #470

Closed
alessandrofelder opened this issue Nov 13, 2024 · 0 comments · Fixed by #471
Closed

[BUG] Path to trained model from brainmapper is a str, and doesn't have .suffix attribute #470

alessandrofelder opened this issue Nov 13, 2024 · 0 comments · Fixed by #471
Assignees
@alessandrofelder
Labels
bug Something isn't working

Comments

@alessandrofelder
Copy link
Member

alessandrofelder commented Nov 13, 2024 •
edited
Loading

Describe the bug
We need the path to the keras model to be a Path to call .suffix on it, but brainmapper parses it as a string

To Reproduce
run brainmapper and pass --trained-model <path to model>- thanks to @JRegg66 for reporting!

Expected behaviour
We can pass trained models from brainmapper without issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessandrofelder alessandrofelder

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ensure trained_model is a Path before calling .suffix brainglobe/cellfinder
1 participant
@alessandrofelder