New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passlog files not deleted when custom pass directory is set #287

Open

jakubzieba opened this issue May 29, 2023 · 0 comments

Labels

bug good first issue

jakubzieba commented May 29, 2023

Describe the bug
When you set custom pass directory via builder (FFmpegBuilder().setPassDirectory()), generated passlog files is not deleted because in deletPassLog function https://github.com/bramp/ffmpeg-cli-wrapper/blob/master/src/main/java/net/bramp/ffmpeg/job/TwoPassFFmpegJob.java#L41 this directory is not use but always "" is set

Expected behavior
All passlog files should be deleted when custom pass directory is set

Version (if applicable):

OS: Linux
Java Version 17
Library Version: 0.7.0

Euklios added bug good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment