Skip to content

Node.js 24 build issues #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsumners-nr opened this issue May 6, 2025 · 7 comments · Fixed by #3462
Closed

Node.js 24 build issues #3458

jsumners-nr opened this issue May 6, 2025 · 7 comments · Fixed by #3462
Assignees
@hjr3

Comments

@jsumners-nr
Copy link

FYI, pg-native does not seem to be building correctly against Node.js 24. https://github.com/newrelic/node-newrelic/actions/runs/14866986493/job/41746156952?pr=3080#step:6:674 shows the errors.
@hjr3
Copy link
Collaborator

hjr3 commented May 10, 2025

Caused by brianc/node-libpq#108

@hjr3 hjr3 self-assigned this May 10, 2025
@brianc brianc mentioned this issue May 12, 2025
Merged
@jsumners-nr
Copy link
Author

@brianc do you have an estimation on when a release might occur that includes the fix?

@brianc
Copy link
Owner

brianc commented May 12, 2025

do you have an estimation on when a release might occur that includes the fix?

today

@jsumners-nr
Copy link
Author

Awesome. Thanks.

@brianc
Copy link
Owner

brianc commented May 12, 2025

released [email protected] and [email protected] w/ the fix. ty for your patience!

@jsumners-nr
Copy link
Author

Thank you. Our tests are now passing 🎉

@brianc
Copy link
Owner

brianc commented May 12, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjr3 hjr3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump libpq & nan version dep for node24 compat brianc/node-postgres
3 participants
@hjr3 @brianc @jsumners-nr