Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brisa 192 can't use external plugins #449

Closed
AlbertSabate opened this issue Sep 2, 2024 · 2 comments · Fixed by #450 or #452
Closed

Brisa 192 can't use external plugins #449

AlbertSabate opened this issue Sep 2, 2024 · 2 comments · Fixed by #450 or #452
Labels
bug Something isn't working

Comments

@AlbertSabate
Copy link
Collaborator

AlbertSabate commented Sep 2, 2024

Version 191 - Working but on 192 I start getting this error.

PHOTO-2024-09-03-00-57-15

@AlbertSabate AlbertSabate added the bug Something isn't working label Sep 2, 2024
@aralroca
Copy link
Collaborator

aralroca commented Sep 2, 2024

Curiously, as an alternative to CSS Parser I was looking at lightlingcss in the past, which is the one that crashes when you make the build. I stopped looking at it as an alternative because it also crashed when building...Here is the related issue:

Previously the file brisa.config.ts was read in runtime from outside the build to access the file without compiling. Now after making the change to make the build standalone and transportable if it is compiled and put inside the build. It is probably not needed in development, but this bug would still happen in production. We will have to look at how to solve this problem, other libraries to compile them is not a problem and Bun builder interprets them well to put them in the bundle.

@aralroca
Copy link
Collaborator

aralroca commented Sep 3, 2024

I reopen this issue to change the solution to another one: add external field to brisa.config.ts to tell external libreries to skip the build of them. Bun builder reference: https://bun.sh/docs/bundler#external

Perhaps with this change we can make a “workaround” and copy the non-compiled dependencies into the build, so that it remains a standalone and transportable build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants