Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attribute as undefined should not set the attribute #539

Closed
aralroca opened this issue Oct 10, 2024 · 0 comments · Fixed by #543
Closed

attribute as undefined should not set the attribute #539

aralroca opened this issue Oct 10, 2024 · 0 comments · Fixed by #543
Assignees
@aralroca
Labels
bug Something isn't working

Comments

@aralroca
Copy link
Collaborator

When the attribute is undefined right now, the WC renders “undefined, " which is incorrect. We should not set the attribute. In fact, during the SSR it is fine, it is then in the WC rendering that it is not fine.

Detected by @anubra266
@aralroca aralroca added the bug Something isn't working label Oct 10, 2024
@aralroca aralroca self-assigned this Oct 10, 2024
@aralroca aralroca mentioned this issue Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aralroca aralroca

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: skip set attribute when value is undefined brisa-build/brisa
1 participant
@aralroca