Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getClientDetails and getUserDetails #209

Open
bshaffer opened this issue Aug 12, 2013 · 1 comment
Open

Remove getClientDetails and getUserDetails #209

bshaffer opened this issue Aug 12, 2013 · 1 comment
Milestone

Comments

@bshaffer
Copy link
Owner

Consider removing these methods from the interface and replace them with the explicit calls being asked for. For instance, the methods should be getUserId, getRedirectUri, etc. The querying can then be handled internally however the author of the storage class seels best.

@frequenc1
Copy link

I really like the idea of pulling this out. We are having issues because we are using multiple instances of redis as our data storage (user credentials, admin credentails, token storage), Our Storage Class is getting way to army knife so anything that pulls these kinda of methods out are great. Thanks!

@bshaffer bshaffer modified the milestones: v2.0.0, v1.1 Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants