Add TODO about Poly1305 alignment requirement.

briansmith · briansmith · commit b6cfc4a22935 · 2016-10-04T16:29:41.000-10:00
diff --git a/src/aead/chacha20_poly1305.rs b/src/aead/chacha20_poly1305.rs
@@ -166,6 +166,10 @@ fn poly1305_init(state: &mut [u8; POLY1305_STATE_LEN],
     }
 }
 
+// XXX: The BoringSSL code says that `poly1305_finish` requires a
+// 16-byte-aligned output, but we're not ensuring 16-byte alignment because we
+// can't in Rust yet. Where does this alignment requirement come from?
+// TODO: address this.
 #[inline(always)]
 fn poly1305_finish(state: &mut [u8; POLY1305_STATE_LEN],
                    tag_out: &mut [u8; aead::TAG_LEN]) {

Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,10 @@ fn poly1305_init(state: &mut [u8; POLY1305_STATE_LEN],`
`166`	`166`	`}`
`167`	`167`	`}`
`168`	`168`
	`169`	+// XXX: The BoringSSL code says that `poly1305_finish` requires a
	`170`	`+// 16-byte-aligned output, but we're not ensuring 16-byte alignment because we`
	`171`	`+// can't in Rust yet. Where does this alignment requirement come from?`
	`172`	`+// TODO: address this.`
`169`	`173`	`#[inline(always)]`
`170`	`174`	`fn poly1305_finish(state: &mut [u8; POLY1305_STATE_LEN],`
`171`	`175`	`tag_out: &mut [u8; aead::TAG_LEN]) {`