File tree Expand file tree Collapse file tree 2 files changed +11
-2
lines changed Expand file tree Collapse file tree 2 files changed +11
-2
lines changed Original file line number Diff line number Diff line change @@ -922,7 +922,7 @@ jQuery.fn.extend({
922
922
// ( event ) dispatched jQuery.Event
923
923
var handleObj = types . handleObj ;
924
924
jQuery ( types . delegateTarget ) . off (
925
- handleObj . namespace ? handleObj . type + "." + handleObj . namespace : handleObj . type ,
925
+ handleObj . namespace ? handleObj . origType + "." + handleObj . namespace : handleObj . origType ,
926
926
handleObj . selector ,
927
927
handleObj . handler
928
928
) ;
Original file line number Diff line number Diff line change @@ -2521,7 +2521,7 @@ test(".on and .off", function() {
2521
2521
} ) ;
2522
2522
2523
2523
test ( "special bind/delegate name mapping" , function ( ) {
2524
- expect ( 6 ) ;
2524
+ expect ( 7 ) ;
2525
2525
2526
2526
jQuery . event . special . slap = {
2527
2527
bindType : "click" ,
@@ -2561,6 +2561,8 @@ test("special bind/delegate name mapping", function() {
2561
2561
delegateType : "click" ,
2562
2562
handle : function ( event ) {
2563
2563
equal ( event . handleObj . origType , "gutfeeling" , "got a gutfeeling" ) ;
2564
+ // Need to call the handler since .one() uses it to unbind
2565
+ return event . handleObj . handler . call ( this , event ) ;
2564
2566
}
2565
2567
} ;
2566
2568
@@ -2579,6 +2581,13 @@ test("special bind/delegate name mapping", function() {
2579
2581
. trigger ( "gutfeeling" )
2580
2582
. remove ( ) ;
2581
2583
2584
+ // Ensure .one() events are removed after their maiden voyage
2585
+ jQuery ( '<p>Gut Feeling</p>' )
2586
+ . one ( "gutfeeling" , jQuery . noop )
2587
+ . trigger ( "gutfeeling" ) // This one should
2588
+ . trigger ( "gutfeeling" ) // This one should not
2589
+ . remove ( ) ;
2590
+
2582
2591
delete jQuery . event . special . gutfeeling ;
2583
2592
} ) ;
2584
2593
You can’t perform that action at this time.
0 commit comments