Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

Add ngrx dependency and rewrite authentication to use ngrx store #388

Open
zolotyx opened this issue Aug 14, 2017 · 2 comments
Open

Add ngrx dependency and rewrite authentication to use ngrx store #388

zolotyx opened this issue Aug 14, 2017 · 2 comments
Assignees

Comments

@zolotyx
Copy link
Contributor

zolotyx commented Aug 14, 2017

  1. Please move authentication code to Auth module
  • Add required selectors/reducers/effects
  • Change the way UI handles login/logout actions
  1. This issue covers the following requirements:
    [REQ_GEN_002] A user should be able to view brief information about his profile in the main menu.

Connected to #1225

Mockup
2018-11-09 15 07 24

@tamazlykar
Copy link
Collaborator

tamazlykar commented Jan 9, 2019

My previous code for this issue (work not done). Click
What I was trying to do:

  • Rewrite new components for login with the store.
  • Add global auth store that keeps only some login data (not all).
  • Add auth page store to keep auth page state.
  • Get current user data from account store. So the user should be downloaded after login. We can provide selector from the account store, auth store or both (auth can reexport the selector)
  • Create some component\effect that will be download all data needed for the app (e.g. user, user-tags, VM etc.) between login and the main app. I was thinking about data resolver. (I think we can extract this task to another issue).

Example of ngrx auth store check here

@elenaustyugova elenaustyugova added this to the Release 1.411.29 milestone Jan 30, 2019
@HeyRoach
Copy link
Contributor

HeyRoach commented Jan 31, 2019

Still, work in progress

get my branch

git fetch https://github.com/HeyRoach/cloudstack-ui.get 388-auth:YOUR-BRANCH-NAME

@elenaustyugova elenaustyugova assigned dron8552 and unassigned HeyRoach Feb 1, 2019
@elenaustyugova elenaustyugova removed this from the Release 1.411.30 milestone Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants